Skip to content

Convert to Dist::Zilla #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Convert to Dist::Zilla #26

wants to merge 4 commits into from

Conversation

kenahoo
Copy link
Member

@kenahoo kenahoo commented Jun 19, 2013

I'd like to use Dist::Zilla to manage the dist.

There are still several things to fix before we pull this in, mostly custom stuff we do during packaging:

  • the <remove_me> stuff in Build.PL
  • make sure the generated MANIFEST is really the same
  • generate a META.json
  • verify that META.yml contains what it's supposed to contain
  • =item <autogenerated_accessors> in lib/Module/Build/API.pod
  • the <action_list> in lib/Module/Build.pm POD
  • can't let zilla set $VERSION in lib/Module/Build/Base.pm automatically, omitting it causes a compile error when we use $VERSION later in the code.

@kenahoo
Copy link
Member Author

kenahoo commented Jun 19, 2013

We also have to keep the manual $VERSION assignment in lib/Module/Build.pm, because (at least) the realclean action depends on having a version defined. The real problem here is probably that we're running code directly from lib/.

@Leont
Copy link
Member

Leont commented Jun 20, 2013

Not entirely sure it's a good idea to do this. Dogfooding can help against breaking stuff.

Either way, I released a Substitute plugin for dzil, that should make the rewriting of <autogenerated_accessors> and <action_list> easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants