perlpacktut: Remove some jargon #23251
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeenan
reviewed
May 4, 2025
pod/perlpacktut.pod
Outdated
| this is likely to remind you of a dump program, or some desperate last | ||
| message unfortunate programs are wont to throw at you before they expire | ||
| into the wild blue yonder. Assuming that the variable C<$mem> holds a | ||
| this is likely to remind you of a dump program, or some terse panic |
There was a problem hiding this comment.
While I think your phrasing is an improvement, I have to wonder why unpack is likely to remind me of a dump program or a panic message.
There was a problem hiding this comment.
This could be improved by swapping the order of the sentence, like "Since this is likely to remind you..., let's use unpack."
khwilliamson
force-pushed
the
perlpack_desperate
branch
from
9b51d83 to
070b513
Compare
|
I delved further into this, and think the result of the latest push is much better. |
tonycoz
reviewed
May 7, 2025
Comment on lines
+64
to
+66
| print unpack( 'A*', $mem), "\n" | ||
|
|
||
| A MAN A PLAN A CANAL PANAMA |
There was a problem hiding this comment.
This is no different to:
print $mem, "\n";
I don't see how it adds anything
There was a problem hiding this comment.
I think this pod needs more extensive changes, so closing this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22697
That a native English speaker could be confused by this is prima facie evidence that the wording should be improved. It's al right to be clever, but not at the expense of clarity.