[VSP-1602] Added new Share link UI #368
Conversation
| requireParentFragment().requireParentFragment().findNavController() | ||
| .navigate(R.id.action_filesContainerFragment_to_shareLinkFragment, bundle) | ||
| //TODO Replace with new Share Link Settings | ||
| // requireParentFragment().requireParentFragment().findNavController() |
There was a problem hiding this comment.
I think we should keep the old logic here, until we update the FileViewOptionsFragment with the new menu as well.
| true | ||
| } | ||
| //TODO Replace with new Share Link Settings | ||
| // R.id.shareLinkFragment -> { |
There was a problem hiding this comment.
I think we should keep the old logic here, until we update the FileViewOptionsFragment with the new menu as well.
| onRecordSelectedEvent.value = it | ||
| } | ||
|
|
||
| private fun showShareManagementFragment(record: Record?) { |
There was a problem hiding this comment.
This is called from a notification, we should not change this implementation yet.
| import org.permanent.permanent.viewmodels.ShareManagementViewModel | ||
| import java.util.Calendar | ||
|
|
||
| class ShareManagementFragment : PermanentBottomSheetFragment() { |
There was a problem hiding this comment.
We should keep the old implementation until we update the FileViewOptionsFragment with the new menu as well.
| Box( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .fillMaxHeight(0.9f) |
There was a problem hiding this comment.
I would make it a bit higher like in the design and other screens we already have: .fillMaxHeight(0.95f)
| appContext.getString(R.string.share_management_share_link), _shareLink.value | ||
| ) | ||
| clipboard.setPrimaryClip(clip) | ||
| //showMessage.value = appContext.getString(R.string.share_management_link_copied) |
There was a problem hiding this comment.
remove this please
| @@ -1,700 +0,0 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <layout xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
We should keep the old implementation until we update the FileViewOptionsFragment with the new menu as well.
| app:destination="@id/fileMetadataFragment" | ||
| app:popEnterAnim="@android:anim/slide_in_left" | ||
| app:popExitAnim="@android:anim/slide_out_right" /> | ||
| <action |
There was a problem hiding this comment.
We should keep the old implementation until we update the FileViewOptionsFragment with the new menu as well.
| app:popExitAnim="@android:anim/slide_out_right" /> | ||
| </fragment> | ||
|
|
||
| <fragment |
There was a problem hiding this comment.
We should keep the old implementation until we update the FileViewOptionsFragment with the new menu as well.
| android:label="@string/main_navigation_title_search" | ||
| tools:layout="@layout/fragment_record_search" /> | ||
|
|
||
| <fragment |
There was a problem hiding this comment.
We should keep the old implementation until we update the FileViewOptionsFragment with the new menu as well.
| .wrapContentHeight() | ||
| ) { | ||
| SheetHeader( | ||
| title = "Share Item", onCloseClick = onClose |
There was a problem hiding this comment.
Move please "Share item" to strings file.
2 participants
No description provided.