Skip to content

Conversation

@liam-lloyd
Copy link
Member

Copied files should have corresponding AIPs and DIPs just like directly uploaded files. Running them through Archivematica is the simplest way to achieve this.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.22%. Comparing base (7c45bc7) to head (521b7df).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #531   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files         101      101           
  Lines        2416     2416           
  Branches      400      402    +2     
=======================================
  Hits         2373     2373           
  Misses         39       39           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cecilia-donnelly
Copy link
Member

How would you recommend testing this? Look at the dashboard for a copied file, maybe.

@liam-lloyd
Copy link
Member Author

How would you recommend testing this? Look at the dashboard for a copied file, maybe.

We'd have to deploy it to dev, and then yes, check for a copied file showing up in the Archivematica dashboard.

@slifty
Copy link
Collaborator

slifty commented Oct 23, 2025

The above raises a key point: we may want (need) to consider updating our devenv to incorporate archivematica locally so we can more effectively test changes like this. I'll open an issue in devenv to capture that concept!

Copy link
Member

@cecilia-donnelly cecilia-donnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this and didn't see the copied record appear in the Archivematica dashboard, unfortunately. I did upload one and see it in the "Transfer" tab successfully.

I don't actually know where these recordcreate messages are created, or else I would look there to see what might be going on.

Copied files should have corresponding AIPs and DIPs just like directly
uploaded files. Running them through Archivematica is the simplest way
to achieve this.
@liam-lloyd liam-lloyd force-pushed the per-10323_run_copies_through_archivematica branch from 6492f0d to 521b7df Compare October 24, 2025 19:39
@liam-lloyd
Copy link
Member Author

I tried this and didn't see the copied record appear in the Archivematica dashboard, unfortunately. I did upload one and see it in the "Transfer" tab successfully.

I don't actually know where these recordcreate messages are created, or else I would look there to see what might be going on.

I forgot to update the filter between SNS and SQS to allow copy events to go through, it's fixed now.

Copy link
Member

@cecilia-donnelly cecilia-donnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied a document on dev and saw it go through on the Archivematica dashboard. Thanks @liam-lloyd !

@liam-lloyd liam-lloyd merged commit 5d59cae into main Oct 30, 2025
41 of 42 checks passed
@liam-lloyd liam-lloyd deleted the per-10323_run_copies_through_archivematica branch October 30, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants