-
Notifications
You must be signed in to change notification settings - Fork 1
Run Archivematica on copied files #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 101 101
Lines 2416 2416
Branches 400 402 +2
=======================================
Hits 2373 2373
Misses 39 39
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
How would you recommend testing this? Look at the dashboard for a copied file, maybe. |
We'd have to deploy it to dev, and then yes, check for a copied file showing up in the Archivematica dashboard. |
|
The above raises a key point: we may want (need) to consider updating our devenv to incorporate archivematica locally so we can more effectively test changes like this. I'll open an issue in devenv to capture that concept! |
cecilia-donnelly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this and didn't see the copied record appear in the Archivematica dashboard, unfortunately. I did upload one and see it in the "Transfer" tab successfully.
I don't actually know where these recordcreate messages are created, or else I would look there to see what might be going on.
Copied files should have corresponding AIPs and DIPs just like directly uploaded files. Running them through Archivematica is the simplest way to achieve this.
6492f0d to
521b7df
Compare
I forgot to update the filter between SNS and SQS to allow copy events to go through, it's fixed now. |
cecilia-donnelly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied a document on dev and saw it go through on the Archivematica dashboard. Thanks @liam-lloyd !
Copied files should have corresponding AIPs and DIPs just like directly uploaded files. Running them through Archivematica is the simplest way to achieve this.