Update deploys to work smoothly when new services are added #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when we add a new service we have to deploy it first manually, because the automated deploy processes rely on all the services already existing. This commit updates the terraform to avoid that problem, so new services can be deployed like any other change.
liam-lloyd
force-pushed
the
per-10377_make_deploys_work_with_new_workloads
branch
from
679dccc to
de969ea
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 102 102
Lines 2458 2458
Branches 408 410 +2
=======================================
Hits 2415 2415
Misses 39 39
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we add a new service we have to deploy it first manually, because the automated deploy processes rely on all the services already existing. This commit updates the terraform to avoid that problem, so new services can be deployed like any other change.