Skip to content

Conversation

@crisnicandrei
Copy link
Contributor

Add checkbox for email opt in option to the signup page

@k8lyn6 I kept the checkboxes in the front, because it was never mentioned to use the iOS looking ones. Should I change them to those?

@crisnicandrei crisnicandrei changed the title PER-9892 PER-9892 Add opt in option to the sign up page Oct 31, 2024
@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.72%. Comparing base (5ae4183) to head (7293e05).
Report is 83 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   42.64%   42.72%   +0.07%     
==========================================
  Files         357      357              
  Lines       10981    10982       +1     
  Branches     1795     1795              
==========================================
+ Hits         4683     4692       +9     
+ Misses       6140     6129      -11     
- Partials      158      161       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8lyn6 k8lyn6 self-requested a review October 31, 2024 14:54
@k8lyn6
Copy link
Collaborator

k8lyn6 commented Oct 31, 2024

@crisnicandrei I'd say to do whatever is in the design unless it poses a problem. Do we have those already in the app somewhere? Will it be a lot of effort to use the sliders?

@crisnicandrei
Copy link
Contributor Author

@k8lyn6 we do have them! I just wanted to check with you about this firat. I will change them tomorrow! Thanks!

@crisnicandrei
Copy link
Contributor Author

@k8lyn6 I have changed the checkboxes to toggles!

Copy link
Collaborator

@k8lyn6 k8lyn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! I noticed that the toggles look a little different when turned off. From the design, it looks like the bubble of the toggle should be more transparent, so you can see it's a toggle. I've attached two screenshots to show the difference. If you have any questions about it, I'd ask Tibi or Natalie.
Screenshot 2024-11-01 at 9 48 41 AM
Screenshot 2024-11-01 at 9 48 31 AM

The API calls look like they're working correctly to Mailchimp and getting tagged correctly. Thanks Andrei!

@crisnicandrei
Copy link
Contributor Author

@k8lyn6 pushed the changes. Thank you!

@k8lyn6 k8lyn6 self-requested a review November 1, 2024 14:09
Copy link
Collaborator

@k8lyn6 k8lyn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's better. Thanks for the quick change!

@crisnicandrei crisnicandrei force-pushed the PER-9892-add-email-opt-in branch from e5f4e07 to 7293e05 Compare November 1, 2024 14:29
@crisnicandrei crisnicandrei merged commit d547367 into main Nov 4, 2024
4 checks passed
@crisnicandrei crisnicandrei deleted the PER-9892-add-email-opt-in branch November 4, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants