-
Notifications
You must be signed in to change notification settings - Fork 1
PER-9892 Add opt in option to the sign up page #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 42.64% 42.72% +0.07%
==========================================
Files 357 357
Lines 10981 10982 +1
Branches 1795 1795
==========================================
+ Hits 4683 4692 +9
+ Misses 6140 6129 -11
- Partials 158 161 +3 ☔ View full report in Codecov by Sentry. |
|
@crisnicandrei I'd say to do whatever is in the design unless it poses a problem. Do we have those already in the app somewhere? Will it be a lot of effort to use the sliders? |
|
@k8lyn6 we do have them! I just wanted to check with you about this firat. I will change them tomorrow! Thanks! |
|
@k8lyn6 I have changed the checkboxes to toggles! |
k8lyn6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! I noticed that the toggles look a little different when turned off. From the design, it looks like the bubble of the toggle should be more transparent, so you can see it's a toggle. I've attached two screenshots to show the difference. If you have any questions about it, I'd ask Tibi or Natalie.


The API calls look like they're working correctly to Mailchimp and getting tagged correctly. Thanks Andrei!
|
@k8lyn6 pushed the changes. Thank you! |
k8lyn6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's better. Thanks for the quick change!
e5f4e07 to
7293e05
Compare
Add checkbox for email opt in option to the signup page
@k8lyn6 I kept the checkboxes in the front, because it was never mentioned to use the iOS looking ones. Should I change them to those?