design changes to final onboarding screen #487
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
==========================================
- Coverage 42.57% 42.56% -0.01%
==========================================
Files 357 357
Lines 10984 10984
Branches 1795 1795
==========================================
- Hits 4676 4675 -1
Misses 6149 6149
- Partials 159 160 +1 ☔ View full report in Codecov by Sentry. |
yeslikesolo
left a comment
yeslikesolo
left a comment
There was a problem hiding this comment.
- Looks like the icons aren't working for me
- Clicking on the underlined link "viewing our help articles here." takes me back to the log in screen. I think it should take us to the Knowledge Base instead ? (Idk what the link was before)
|
@yeslikesolo yes i asked @k8lyn6 for the link because I did not have it |
|
@yeslikesolo can you paste it here please so i can add it? |
|
@crisnicandrei the link should take you to https://permanent.zohodesk.com/portal/en/kb/permanent-legacy-foundation |
|
@k8lyn6 @meisekimiu @yeslikesolo updated the url |
yeslikesolo
left a comment
yeslikesolo
left a comment
There was a problem hiding this comment.
The link works great, thanks @crisnicandrei !
One thing @k8lyn6 and I spoke about was changing the link to open in a new tab. Although it is best practice to open links in the same tab, if clicked on, the link currently lives in an area that disrupts the user flow to complete account creation and move forward in the onboarding process. It also signs them out of the process. Could we change this please? Let me know if you have any questions! Thanks again, Andrei (:
|
@yeslikesolo pushed the changes |
meisekimiu
left a comment
meisekimiu
left a comment
There was a problem hiding this comment.
(Was waiting for the URL to be resolved before I approved on code review!)
yeslikesolo
left a comment
yeslikesolo
left a comment
There was a problem hiding this comment.
Yay, works great. Thanks @crisnicandrei & @meisekimiu !
meisekimiu
force-pushed
the
PER-9760-upgrade-congrats-screen
branch
from
f92e8e2 to
13ed117
Compare
|
Planning on merging this myself so that I don't get a merge conflict on my own work that touches this component! |
@k8lyn6 the icons work fine for me
I also need a link for the new underlined text:) Thanks!