Fix bug with uploading folders into public #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisekimiu
force-pushed
the
public-upload-folders
branch
2 times, most recently
from
f5e814e to
315ed8b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
- Coverage 42.74% 42.58% -0.16%
==========================================
Files 357 357
Lines 10982 10984 +2
Branches 1795 1795
==========================================
- Hits 4694 4678 -16
- Misses 6127 6146 +19
+ Partials 161 160 -1 ☔ View full report in Codecov by Sentry. |
Asyncronous calls caused by the confirmation dialog that pops up when a user uploads into the public workspace ended up causing some objects to preemptively go out of scope. To fix this, copy the FileSystemEntries from the DataTransferItemList before any async calls so we can pass it directly into `UploadService.uploadFolders`. It seems like we cannot copy the DataTransferItemList directly, but since we only want the FileSystemEntries anyway, we can just save that instead. PER-9879: Dragging a folder into the Public workspace doesn't work
meisekimiu
force-pushed
the
public-upload-folders
branch
from
315ed8b to
13bf487
Compare
crisnicandrei
approved these changes
Nov 12, 2024
yeslikesolo
approved these changes
Nov 14, 2024
Collaborator
yeslikesolo
left a comment
yeslikesolo
left a comment
There was a problem hiding this comment.
Tested all 3 scenarios, they worked great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asynchronous calls caused by the confirmation dialog that pops up when a user uploads into the public workspace ended up causing some objects to preemptively go out of scope. To fix this, copy the FileSystemEntries from the DataTransferItemList before any async calls so we can pass it directly into
UploadService.uploadFolders. It seems like we cannot copy the DataTransferItemList directly, but since we only want the FileSystemEntries anyway, we can just save that instead.I wasn't able to recreate the in-browser deletion behavior in tests with our mocks but if anyone has any ideas I'd be happy to try again.
Stepz 2 Test: