-
Notifications
You must be signed in to change notification settings - Fork 1
design changes to the create archive for me screen #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
design changes to the create archive for me screen #492
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
==========================================
- Coverage 42.71% 42.63% -0.08%
==========================================
Files 359 359
Lines 10974 10974
Branches 1793 1793
==========================================
- Hits 4687 4679 -8
- Misses 6128 6136 +8
Partials 159 159 ☔ View full report in Codecov by Sentry. |
| const continueButton = fixture.debugElement.query( | ||
| By.css('.continue-button'), | ||
| ); | ||
| const continueButton = fixture.debugElement.query(By.css('.continue')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why this usage of fixture.debugElement.query can't use the find function provided by shallow-render?
k8lyn6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@k8lyn6 the icons work well for me locally! Which is the env you are testing on and how can I access it? It seems there might be a problem with how the image paths are handled on it so I would like to take a look, as this is not the first time it happens to the Experience Team |
|
@crisnicandrei I am testing on the |
k8lyn6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we made the above issue a separate ticket so I'm approving this PR!
7ee4300 to
a61a2b7
Compare

No description provided.