Skip to content

Conversation

@crisnicandrei
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.63%. Comparing base (e7d0321) to head (a61a2b7).
Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   42.71%   42.63%   -0.08%     
==========================================
  Files         359      359              
  Lines       10974    10974              
  Branches     1793     1793              
==========================================
- Hits         4687     4679       -8     
- Misses       6128     6136       +8     
  Partials      159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

const continueButton = fixture.debugElement.query(
By.css('.continue-button'),
);
const continueButton = fixture.debugElement.query(By.css('.continue'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why this usage of fixture.debugElement.query can't use the find function provided by shallow-render?

@crisnicandrei crisnicandrei requested a review from k8lyn6 November 26, 2024 16:42
Copy link
Collaborator

@k8lyn6 k8lyn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Small thing: the archive icon is broken for me on this page. I've attached a screenshot. Could you look into this? I tried on both Chrome and Firefox.
Screenshot 2024-11-26 at 1 29 25 PM

@crisnicandrei
Copy link
Contributor Author

@k8lyn6 the icons work well for me locally! Which is the env you are testing on and how can I access it? It seems there might be a problem with how the image paths are handled on it so I would like to take a look, as this is not the first time it happens to the Experience Team

@k8lyn6
Copy link
Collaborator

k8lyn6 commented Nov 27, 2024

@crisnicandrei I am testing on the dev environment, which you can access at dev.permanent.org/app/auth/login (you can just create a test account there).

@k8lyn6 k8lyn6 self-requested a review December 2, 2024 15:43
Copy link
Collaborator

@k8lyn6 k8lyn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we made the above issue a separate ticket so I'm approving this PR!

@crisnicandrei crisnicandrei force-pushed the PER-9761-update-create-archive-for-me-screen branch from 7ee4300 to a61a2b7 Compare December 3, 2024 15:41
@crisnicandrei crisnicandrei merged commit 358328a into main Dec 3, 2024
4 checks passed
@crisnicandrei crisnicandrei deleted the PER-9761-update-create-archive-for-me-screen branch December 3, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants