Skip to content

[PER-10316] Create account sticky footer disappears #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aasandei-vsp merged 3 commits into from
Dec 2, 2025
Merged

[PER-10316] Create account sticky footer disappears #814

aasandei-vsp merged 3 commits into from
Dec 2, 2025
+8 −49

Conversation

@aasandei-vsp
Copy link
Contributor

@aasandei-vsp aasandei-vsp commented Nov 11, 2025 •
edited
Loading

STEPS TO TEST:

  1. Create an account or log in to an existent one
  2. Upload a file, create a folder or use an existent record/folder
  3. Create a share link
  4. Select the restricted option for Link Type
  5. Copy the link
  6. Open an incognito tab or a new window where you are not logged in
  7. Paste the link
    EXPECTED: The preview of the share and the sticky footer will be covered by a layover and a modal.
  8. Click outside the modal.
    EXPECTED: The modal will close, the sticky footer will stay on the screen
  9. Click the "x" button on the sticky footer
    EXPECTED: The sticky footer will disappear
  10. Click on the preview of the file/folder
    EXPECTED: The modal appears again, the sticky footer does not

Issue: PER-10316 Create account sticky footer disappears

@aasandei-vsp aasandei-vsp self-assigned this Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.03%. Comparing base (6074c02) to head (526e28b).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
- Coverage   47.05%   47.03%   -0.03%     
==========================================
  Files         372      372              
  Lines       11494    11492       -2     
  Branches     1907     1907              
==========================================
- Hits         5409     5405       -4     
- Misses       5897     5898       +1     
- Partials      188      189       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasandei-vsp aasandei-vsp changed the title Per 10316 create account sticky footer disappears [PER-10316] Create account sticky footer disappears Nov 12, 2025
cecilia-donnelly
cecilia-donnelly approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@cecilia-donnelly cecilia-donnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aasandei-vsp !

omnignorant
omnignorant approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@omnignorant omnignorant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is working as expected. However, the sticky footer does not appear on initial page load. It takes a few seconds and it seems scrolling the page after clicking out of the modal for it to appear. Other than the delay in footer loading, it seems to work! see screen recording.

Screen.Recording.2025-11-19.at.2.20.45.AM.mov

@aasandei-vsp aasandei-vsp force-pushed the PER-10316-create-account-sticky-footer-disappears branch from dfc19ba to 4e98005 Compare November 19, 2025 13:12
@aasandei-vsp
Copy link
Contributor Author

aasandei-vsp commented Nov 19, 2025

Thank you, @omnignorant This was very good feedback. Two important notes from this:

  1. The fact that you need to scroll to see the sticky banner is not normal UX behavior, so I fixed that, I'll put it back in PR.
  2. The delay in sticky footer appearing seems to be intended behavior in the code. I can leave it as is or remove it, I do not think there is a rule for this.

@cecilia-donnelly @slifty I will put this back for review, only the last commit has not been checked.

@aasandei-vsp aasandei-vsp requested review from cecilia-donnelly and omnignorant and removed request for omnignorant November 19, 2025 13:16
@aasandei-vsp aasandei-vsp force-pushed the PER-10316-create-account-sticky-footer-disappears branch from 4e98005 to fe5b797 Compare November 20, 2025 16:32
@aasandei-vsp aasandei-vsp requested review from omnignorant and removed request for omnignorant November 21, 2025 08:27
slifty
slifty approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense to me, thank you!

@aasandei-vsp aasandei-vsp added the QA This issue is ready for QA / user acceptance testing label Nov 27, 2025
omnignorant
omnignorant approved these changes Dec 1, 2025
View reviewed changes
Copy link
Member

@omnignorant omnignorant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely working now!

@aasandei-vsp
Make sticky footer remain visible when the modal disappears
19d8207 
In order for the sticky footer to remain on the screen, when the modal disappears,
the listener had to be removed, because it specifically closes the component when
the user clicks outside of it. This seems to be more like legacy code that has been
used in the past, because the footer component is only used in the share preview and
the listener produces the bug.

Issue: PER-10316 Create account sticky footer disappears
@aasandei-vsp
Make sticky footer stay on screen when modal appears again
d350934 
When clicking the file preview, the create account modal appears again
but the sticky footer was disappearing. The method removed above will
let the component remain visible at all times, up until the user clicks
the x button. This behaviour is loosely consistent with the behaviour
that the accept share sticky footer has.

Issue: PER-10316 Create account sticky footer disappears
@aasandei-vsp
Make sticky footer appear even for scrollable pages
526e28b 
The sticky footer for account creation would appear for pages with a lot of records
and folders only on scroll, which is not correct, so the checks for scroll height
had to be removed

Issue: PER-10316 Create account sticky footer disappears
@aasandei-vsp aasandei-vsp force-pushed the PER-10316-create-account-sticky-footer-disappears branch from fe5b797 to 526e28b Compare December 2, 2025 08:11
@aasandei-vsp aasandei-vsp merged commit fa260c0 into main Dec 2, 2025
9 checks passed
@aasandei-vsp aasandei-vsp deleted the PER-10316-create-account-sticky-footer-disappears branch December 2, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slifty slifty slifty approved these changes

@omnignorant omnignorant omnignorant approved these changes

@cecilia-donnelly cecilia-donnelly Awaiting requested review from cecilia-donnelly

Assignees

@aasandei-vsp aasandei-vsp

Labels

QA This issue is ready for QA / user acceptance testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aasandei-vsp @slifty @cecilia-donnelly @omnignorant