Skip to content

Conversation

@aasandei-vsp
Copy link
Contributor

@aasandei-vsp aasandei-vsp commented Nov 12, 2025

STEPS TO TEST:

Unlisted share

  1. Create a new account or log in to an existing one
  2. Create a share link for a folder or file
  3. Select the "Anyone can view" option from the Link Type dropdown
  4. Copy the created share link
  5. Open an incognito tab or a new browser window
  6. Log in with a different account or create a new one
  7. Paste the created share link
    EXPECTED: The file or folder preview should be visible and a "My archive" button should be present on top/right of the screen
  8. Click the "My archive" button
    EXPECTED: It should redirect to the private folder of the user's selected archive

OTHERS SCENARIOS TO TEST:

Restricted share

  1. Create a new account or log in to an existing one
  2. Create a share link for a folder or file
  3. Select the "Restricted" option from the Link Type dropdown
  4. Copy the created share link
  5. Open an incognito tab or a new browser window
  6. Log in with a different account or create a new one
  7. Paste the created share link
    EXPECTED: The file or folder preview should be visible, together with the sticky footer for accepting the share and a "My archive" button should be present on top/right of the screen
  8. Click the "My archive" button
    EXPECTED: It should redirect to the private folder of the user's selected archive

Issue: PER-10324 Share archive button not working

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.98%. Comparing base (348a823) to head (b34bf90).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
+ Coverage   46.93%   46.98%   +0.05%     
==========================================
  Files         372      372              
  Lines       11444    11445       +1     
  Branches     1896     1896              
==========================================
+ Hits         5371     5378       +7     
+ Misses       5885     5881       -4     
+ Partials      188      186       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The button was not working because angular was navigating to a
route that should make authenticated calls to the BE and not by
using a shareToken for authorization.

Issue: PER-10324 Share archive button not working
@aasandei-vsp aasandei-vsp force-pushed the PER-10324-share-archive-button-not-working branch from 6ddb6fb to b34bf90 Compare November 12, 2025 12:54
Copy link
Member

@cecilia-donnelly cecilia-donnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works! I expected this solution to mean that the back button wouldn't work to get back to the shared item, since the share token would be undefined, but it did work correctly when I tried it.

It does seem surprising to me that "My Archive" would fail without this change. I would expect that we'd check the share token and if that didn't work fall back to normal authentication/authorization. Is that something we should be planning for future work?

@aasandei-vsp
Copy link
Contributor Author

@cecilia-donnelly We indeed do not have a fallback to normal if the token is not working, but I think it's a very good idea for future work. It is a FE issue, because we decide in the web-app how to authenticate.

@omnignorant omnignorant changed the title [PER-20324] Fix "My archive" button not working on unlisted share link [PER-10324] Fix "My archive" button not working on unlisted share link Nov 17, 2025
Copy link
Member

@omnignorant omnignorant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not certain how to review this PR. I think it worked as expected based on the test plan provided BUT the share link functionality definitely did not work as expected.

  1. opening the both the unlisted and restricted links both show the same blurry preview screen (see screenshot as an example)
  2. in both cases, clicking My Archive took me to my archive as expected.

Based on the test plan strictly, I am going to approve this PR.

However, here are my concerns:

  • unlisted share links are not displaying the item thumbnails
  • the my archive button works, but the "View in my Archive" button does not work for restricted links after access request has been accepted.
Screen.Recording.2025-11-19.at.2.20.45.AM.mov
Screenshot 2025-11-19 at 2 25 59 AM Screenshot 2025-11-19 at 2 26 51 AM Screenshot 2025-11-19 at 2 27 00 AM

@aasandei-vsp
Copy link
Contributor Author

I will be closing this PR, as the code broke unlisted share, while fixing a very small bug.
@omnignorant @cecilia-donnelly @slifty Sorry for wasting your time on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants