-
Notifications
You must be signed in to change notification settings - Fork 1
[PER-10324] Fix "My archive" button not working on unlisted share link #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
==========================================
+ Coverage 46.93% 46.98% +0.05%
==========================================
Files 372 372
Lines 11444 11445 +1
Branches 1896 1896
==========================================
+ Hits 5371 5378 +7
+ Misses 5885 5881 -4
+ Partials 188 186 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The button was not working because angular was navigating to a route that should make authenticated calls to the BE and not by using a shareToken for authorization. Issue: PER-10324 Share archive button not working
6ddb6fb to
b34bf90
Compare
cecilia-donnelly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works! I expected this solution to mean that the back button wouldn't work to get back to the shared item, since the share token would be undefined, but it did work correctly when I tried it.
It does seem surprising to me that "My Archive" would fail without this change. I would expect that we'd check the share token and if that didn't work fall back to normal authentication/authorization. Is that something we should be planning for future work?
|
@cecilia-donnelly We indeed do not have a fallback to normal if the token is not working, but I think it's a very good idea for future work. It is a FE issue, because we decide in the web-app how to authenticate. |
omnignorant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not certain how to review this PR. I think it worked as expected based on the test plan provided BUT the share link functionality definitely did not work as expected.
- opening the both the unlisted and restricted links both show the same blurry preview screen (see screenshot as an example)
- in both cases, clicking My Archive took me to my archive as expected.
Based on the test plan strictly, I am going to approve this PR.
However, here are my concerns:
- unlisted share links are not displaying the item thumbnails
- the my archive button works, but the "View in my Archive" button does not work for restricted links after access request has been accepted.
Screen.Recording.2025-11-19.at.2.20.45.AM.mov
|
I will be closing this PR, as the code broke unlisted share, while fixing a very small bug. |
STEPS TO TEST:
Unlisted share
EXPECTED: The file or folder preview should be visible and a "My archive" button should be present on top/right of the screen
EXPECTED: It should redirect to the private folder of the user's selected archive
OTHERS SCENARIOS TO TEST:
Restricted share
EXPECTED: The file or folder preview should be visible, together with the sticky footer for accepting the share and a "My archive" button should be present on top/right of the screen
EXPECTED: It should redirect to the private folder of the user's selected archive
Issue: PER-10324 Share archive button not working