[PER-10348] Fix public gallery link for records

[aasandei-vsp]

The public gallery links were not generating correctly, because the endpoint for getting the record has changed and the property used to create it, ParentFolderVOs, is not present anymore. Ideally we would fix the backend, but for now this will do the job. One exception is, the link for records that are in the root folder will have 2 extra parameters, but they will work.

Check the issue bellow for more details on how this should be tackled on BE.

Issue: PER-10348 Get public gallery link not working for individual records

STEPS TO TEST:
Root record

1. Create a new account or log in to an existing one
2. Upload a file or click an existing one
3. Publish the file
4. Go to public files and click the record you just published
5. Click Get link
   EXPECTED: A modal with a generated link will appear
6. Click copy link from the modal
7. Paste the link in a new tab/window
   EXPECTED:

• The record preview should load
• You should be able to see all the details
• You should be able to see the left and right arrows if there are multiple records in the root folder

Folder

1. Create a new account or log in to an existing one
2. Create a folder or use an existing one
3. Upload files in the folder or use existing ones
4. Publish the folder
5. Go to public files and click the folder you just published
6. Click Get link
   EXPECTED: A modal with a generated link will appear
7. Click copy link from the modal
8. Paste the link in a new tab/window
   EXPECTED:

• The folder preview should load
• You should be able to click the files and preview them
• You should be able to see the left and right arrows if there are multiple files in the folder

Record in folder

1. Create a new account or log in to an existing one
2. Create a folder or use an existing one
3. Upload files in the folder or use existing ones
4. Publish the folder
5. Go to public files and click the folder you just published
6. Click one of the files in the folder
7. Click Get link
   EXPECTED: A modal with a generated link will appear
8. Click copy link from the modal
9. Paste the link in a new tab/window
   EXPECTED:

• The record preview should load
• You should be able to see all the details
• You should be able to see the left and right arrows if there are multiple records in the parent folder
• You should be able to hit the back arrow and get to the preview of the parent folder

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.06%. Comparing base (fa260c0) to head (c8e7950).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
- Coverage   47.06%   47.06%   -0.01%     
==========================================
  Files         372      372              
  Lines       11492    11495       +3     
  Branches     1907     1909       +2     
==========================================
+ Hits         5409     5410       +1     
  Misses       5897     5897              
- Partials      186      188       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[slifty]

What happens from a UX PoV if this else block's logical conditions are not met? Do we need to cover that case somehow?

[aasandei-vsp]

The parent folder is not added to the root, so the user will land on the public folder. Maybe this should be done indeed better, but I do think it is out of the scope of this bug.

[cecilia-donnelly]

Agreed with @slifty's point about the backend response intentionally being smaller. I'm impressed you were able to work around this, @aasandei-vsp! I do wonder if the extra parameters mean that old links would now be broken. Do you know? I don't think I have one handy unfortunately.

[aasandei-vsp]

@cecilia-donnelly @slifty Sorry, I only added this on the story, forgot to put it on the PR:

I have managed to find a fix for the issue, however, it is not ideal. The right way would be to get the ParentFolderVOs property from the BE, when we call v2/record.
This property is needed in the “src/app/shared/pipes/public-route.pipe.ts” file, to get the following properties: archiveNbr, folder_linkId, folder_linkType, type of the parent.

With the current fix, links are generated and they work.

But there is an exception!
When the link is created for a record that is in the root, properties parentFolderArchiveNumber and parentFolderLinkId are different from the ones of the root, so an extra 2 parameters are added to the root.
EXAMPLE:

• How it looks like: https://local.permanent.org/p/archive/0002-0000/0002-0004/17/record/0002-000d
• How it’s suppose to look like: https://local.permanent.org/p/archive/0002-0000/record/0002-000d

!!Both versions of the link work ok.

TL:DR The old links should work too!

[cecilia-donnelly]

This works! Thanks @aasandei-vsp. Agreed with @slifty's comments about opening an issue and pointing to it from the comment.

[omnignorant]

This appears to be working as expected now!