[PER-10229] Make selected value non-clickable #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
==========================================
- Coverage 47.13% 47.12% -0.01%
==========================================
Files 372 372
Lines 11495 11495
Branches 1912 1912
==========================================
- Hits 5418 5417 -1
- Misses 5895 5896 +1
Partials 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cecilia-donnelly
approved these changes
Dec 9, 2025
cecilia-donnelly
force-pushed
the
PER-10229-click-access-role-dropdown
branch
from
076c093 to
8bad0a3
Compare
omnignorant
approved these changes
Dec 12, 2025
Member
omnignorant
left a comment
omnignorant
left a comment
There was a problem hiding this comment.
works as described. however, I didn't know this was a problem? is it broken on prod?
A native HTML select cannot be triggered programatically to open, because this would post a security risk, so clicking on the selected value that is not part of the select element won't make the options dropdown open. In order to make the selected value look like part of the whole select flow, an absolute positioning is needed, which was already implemented. The issue was that the element would still be clickable, so cancelling the pointer events will make the click trigger go through it, directly to the select element. Issue: PER-10229 Archive-member-invite, access-role-dropdown, click area buggy
aasandei-vsp
force-pushed
the
PER-10229-click-access-role-dropdown
branch
from
8bad0a3 to
fd86124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A native HTML select cannot be triggered programatically to open, because this would post a security risk, so clicking on the selected value that is not part of the select element won't make the options dropdown open. In order to make the selected value look like part of the whole select flow, an absolute positioning is needed, which was already implemented. The issue was that the element would still be clickable, so cancelling the pointer events will make the click trigger go through it, directly to the select element.
Issue: PER-10229 Archive-member-invite, access-role-dropdown, click area buggy
STEPS TO TEST:
EXPECTED: The select dropdown should open
EXPECTED: The option selected in the dropdown is reflected in the list of pending users