Support writing the audio stream back into video#83
Open
Ahuge wants to merge 1 commit intoPeterL1n:masterfrom
Open
Support writing the audio stream back into video#83Ahuge wants to merge 1 commit intoPeterL1n:masterfrom
Ahuge wants to merge 1 commit intoPeterL1n:masterfrom
Conversation
When output_type == video, we can support adding back the audio stream from the original video input.
Author
|
I don't know if you are accepting PRs on this repo. I just found this functionality useful and wanted to offer it upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR remuxes the audio stream back into the output video.
When output_type == video, we can support adding back the audio stream
from the original video input.
It introduces a new
convert_videoflagpassthrough_audio: bool = True.