Fix array indexing when no record is selected #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also allows the message about scrolling to be actually displayed at start.
ProkopRandacek
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the game was started with
m_albumRevealed = -1, the code soon used this negative value to index the albums array, causing out of bounds access. This PR creates a constant for the no album selected state, and checks that this is not the value of them_albumRevealedvariable before indexing into the array.This was also the reason why the message about scrolling wasn't being displayed (at least on my machine), now it also works.
I'm a big fan of games by Amanita Design, and this small piece really reminded them of their game style. Love it!