GroupAlgo #31
Open
GroupAlgo #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ph1Lou
reviewed
May 15, 2024
| import fr.ph1lou.werewolfapi.basekeys.ConfigBase; | ||
|
|
||
| @Configuration(config = @ConfigurationBasic(key = "werewolf.configurations.group_algo.name", loreKey = "werewolf.configurations.group_algo.description", | ||
| appearInMenu = false)) |
There was a problem hiding this comment.
une raison particulière pour ne pas le faire apparaitre dans le menu ?
| Bukkit.broadcastMessage(game.translate(Prefix.ORANGE, "werewolf.announcement.day", | ||
| Formatter.number(event.getNumber()))); | ||
| groupSizeChange(); | ||
| if(game.getConfig().isConfigActive("werewolf.configurations.group_algo.name")){ |
There was a problem hiding this comment.
la clef doit être mise en constante dans la classe ConfigBase dans Werewolfapi
There was a problem hiding this comment.
@Sterll mais du coup la constante que tu as créé tu l'utilise ms pas dans l'annotation ?
There was a problem hiding this comment.
C'est pck j'attendais que tu acceptais la pull request de l'api
| Bukkit.broadcastMessage(game.translate(Prefix.YELLOW, "werewolf.announcement.night", | ||
| Formatter.number(event.getNumber()))); | ||
| groupSizeChange(); | ||
| if(game.getConfig().isConfigActive("werewolf.configurations.group_algo.name")){ |
There was a problem hiding this comment.
idem utilisez la constante définie plus haut
| @@ -0,0 +1,17 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <module version="4"> | |||
There was a problem hiding this comment.
il ne faut pas commit ce fichier à supprimer
| import fr.ph1lou.werewolfapi.annotations.ConfigurationBasic; | ||
| import fr.ph1lou.werewolfapi.basekeys.ConfigBase; | ||
|
|
||
| @Configuration(config = @ConfigurationBasic(key = "werewolf.configurations.group_algo.name", loreKey = "werewolf.configurations.group_algo.description", |
There was a problem hiding this comment.
dans key: utilisez une constante à définir dans ConfigBase dans werewolfapi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now disable the Group Algorithm.