Skip to content

fix(quote): backport PERFMON reserved-bit fix to v0.5.x - #220

Merged
kvinwang merged 1 commit into
release-v0.5.xfrom
backport/tdattributes-v15-v0.5.x
Aug 25, 2026
Merged

fix(quote): backport PERFMON reserved-bit fix to v0.5.x#220
kvinwang merged 1 commit into
release-v0.5.xfrom
backport/tdattributes-v15-v0.5.x

Conversation

@kvinwang

@kvinwang kvinwang commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

Backport #218 to the release-v0.5.x branch created from v0.5.2.

  • exclude TDATTRIBUTES bit 63 (PERFMON) from reserved_other
  • keep bit 39 in the reserved-bit validation

Testing

  • cargo fmt --check
  • cargo test --lib (35 passed)

Copilot AI lite review requested due to automatic review settings August 25, 2026 01:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang
kvinwang force-pushed the backport/tdattributes-v15-v0.5.x branch 3 times, most recently from 67c7925 to 89f4f65 Compare August 25, 2026 02:18
…arse

The & 0x7F mask was incorrectly applied to input[4] (bit 39, a reserved
bit that should be checked) instead of input[7] (bit 63 = PERFMON, which
should be excluded from reserved_other). This caused PERFMON=1 to be
falsely flagged as 'Reserved bits in TD attributes are set'.

The fix moves & 0x7F from input[4] to input[7]:
- input[7] & 0x7F: excludes PERFMON (bit 63) from reserved_other ✓
- input[4] (no mask): bit 39 is now correctly checked as reserved ✓

Signed-off-by: Kun Lai <laikun@linux.alibaba.com>
@kvinwang
kvinwang force-pushed the backport/tdattributes-v15-v0.5.x branch from 89f4f65 to 7a44914 Compare August 25, 2026 02:26
@kvinwang kvinwang changed the title fix(quote): backport TDX 1.5 TD attributes alignment fix(quote): backport PERFMON reserved-bit fix to v0.5.x Aug 25, 2026
@kvinwang
kvinwang merged commit 941f4e2 into release-v0.5.x Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants