refactor: remove user_id fields from API types and simplify upload interface #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface This refactoring removes user_id fields from various API response types across the codebase and simplifies the construe code system upload interface. These changes improve API consistency and reduce unnecessary data exposure. Key changes: - Remove user_id fields from ChatMessageTemplate, ChatSessionTemplate, FhirProviderTemplate, and other response types - Simplify construe upload interface by consolidating UploadRequest types and removing discriminated union - Update upload API documentation to clarify asynchronous processing behavior - Remove async parameter from upload requests (now always asynchronous) - Add name and version fields to ConstrueUploadCodeSystemResponse for better tracking - Update all test cases to reflect the simplified interface and removed fields 🌿 Generated with Fern
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| export type { GetConstrueCodesCodesystemSearchTextRequest } from "./GetConstrueCodesCodesystemSearchTextRequest.js"; | ||
| export type { GetConstrueCodesSystemsCodesystemExportRequest } from "./GetConstrueCodesSystemsCodesystemExportRequest.js"; | ||
| export type { GetConstrueCodesSystemsCodesystemRequest } from "./GetConstrueCodesSystemsCodesystemRequest.js"; | ||
| export type { UploadRequest } from "./UploadRequest.js"; |
There was a problem hiding this comment.
export type prevents runtime access to Format enum values
Medium Severity
The UploadRequest in requests/index.ts is re-exported with export type, which strips the runtime Format const values (Csv, Json) from the namespace. SDK consumers can't use UploadRequest.Format.Csv at runtime — the const is effectively dead code. By contrast, similar enums like GetCodeSystemDetailResponse.Status in types/index.ts are exported with export * and remain fully accessible.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring removes user_id fields from various API response types across the codebase and simplifies the construe code system upload interface. These changes improve API consistency and reduce unnecessary data exposure.
Key changes:
🌿 Generated with Fern
Note
Medium Risk
This is a breaking API surface change for SDK consumers (removed fields and changed
uploadCodeSystemrequest/response types), requiring downstream code updates, but it doesn’t alter auth/transport logic.Overview
Bumps the TypeScript SDK to
6.0.0and removesuser_idfrom multiple generated API response/template types (agent chat messages/sessions, FHIR provider templates, summary templates, MCP server/tool responses, workflows), reducing exposed user-identifying data.Refactors Construe code-system uploads by replacing the prior format-discriminated
UploadRequest*union with a singleconstrue.UploadRequesttype, dropping theasyncflag (uploads are now documented as always async) and updating docs/tests accordingly; upload responses now also include optionalnameandversionfields.Written by Cursor Bugbot for commit 7d52ae3. This will update automatically on new commits. Configure here.