fix(selections): enforce exact list count in ValidateSelections#119
Merged
PhilipWoulfe merged 2 commits intofeat/#86-retrieve-selectionsfrom Mar 12, 2026
Merged
fix(selections): enforce exact list count in ValidateSelections#119PhilipWoulfe merged 2 commits intofeat/#86-retrieve-selectionsfrom
PhilipWoulfe merged 2 commits intofeat/#86-retrieve-selectionsfrom
Conversation
…and add test Co-authored-by: PhilipWoulfe <8867626+PhilipWoulfe@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on "Feat/#86 retrieve selections" PR
fix(selections): enforce exact list count in ValidateSelections
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValidateSelectionsonly checked that 5 non-empty drivers were present, allowing payloads with extra empty/whitespace entries (e.g. 6 items: 5 valid + 1 empty) to pass validation and be persisted as-is — inconsistent withValidateMockSubmissionwhich requiresCount == 5.Changes
SelectionService.ValidateSelections: Added upfrontselections.Count != 5guard before the existing non-empty/distinct checks:SelectionServiceTests: AddedUpsertSelectionAsync_ShouldReject_WhenMoreThanFiveSelectionsSubmittedcovering the 5-valid + 1-empty payload case.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.