Skip to content

feat(Countdown): L3-12092 Sale PLP - Lot timers are misaligned#851

Open
zhenpanda wants to merge 2 commits intomainfrom
L3-12092-Sale-PLP-Lot-timers-are-misaligned
Open

feat(Countdown): L3-12092 Sale PLP - Lot timers are misaligned#851
zhenpanda wants to merge 2 commits intomainfrom
L3-12092-Sale-PLP-Lot-timers-are-misaligned

Conversation

@zhenpanda
Copy link
Copy Markdown
Contributor

@zhenpanda zhenpanda commented Apr 17, 2026

Jira ticket

L3-12092

Screenshots

countdown_row.mp4

Summary

Made countdown to stack on small widths

Change List (describe the changes made to the files)

Acceptance Test (how to verify the PR)

  • Add step by step instructions on how to verify the change

Regression Test

  • (Optional) Add verification steps to make sure this PR doesn't break old functionality

Evidence of testing

  • Post logs, screenshots, etc

Things to look for during review

  • PR title should correctly describe the most significant type of commit. I.e. feat(scope): ... if a minor release should be triggered.
  • All commit messages follow convention and are appropriate for the changes
  • All references to phillips class prefix are using the prefix variable
  • All major areas have a data-testid attribute.
  • Document all props with jsdoc comments
  • All strings should be translatable.
  • Unit tests should be written and should have a coverage of 90% or higher in all areas.

New Components

  • Are there any accessibility considerations that need to be taken into account and tested?
  • Default story called "Playground" should be created for all new components
  • Create a jsdoc comment that has an Overview section and a link to the Figma design for the component
  • Export the component and its typescript type from the index.ts file
  • Import the component scss file into the componentStyles.scss file.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 17, 2026

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit 06ab999
🔍 Latest deploy log https://app.netlify.com/projects/phillips-seldon/deploys/69e288c7ac90e80008df5daa
😎 Deploy Preview https://deploy-preview-851--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant