Skip to content

Conversation

@andrewvy
Copy link
Contributor

@andrewvy andrewvy commented Jun 2, 2014

Added days, weeks, years to duration conversion. Following the Julian calendar. (1 year = 365.25 days)

Also, updated README.md to include mass conversions.

@Philzen
Copy link
Owner

Philzen commented Jun 4, 2014

Let me medidate a bit over this - i'm not sure the scope of measurement.js is for datetime stuff - at least not in the core (right now i don't want to re-build). Maybe this should better be in a pluggable file mechanism as planned for 0.3, see roadmap.

Also - pls make sure not to send PRs to versioned branches going forward, as they should always contain the released state, so either create a seperate one or send the PR to master. I will then merge into the versioned branch right before release.

But anyway keep on the contributions ;) Thanks heaps!

@andrewvy
Copy link
Contributor Author

andrewvy commented Jun 4, 2014

Right! This is one of the first few pull requests that I've contributed to
an open source project, so I'm not quite sure of the formalities.

I'll take a look at the roadmap and see what else I can take on.

@Philzen
Copy link
Owner

Philzen commented Jun 5, 2014

This is one of the first few pull requests that I've contributed to
an open source project, so I'm not quite sure of the formalities.

No worries - the formalities are up to the maintainer to put into the readme under a "contribution guidelines" section, so it's actually my bad here ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants