Multiple Fix - #171
Conversation
MatchesTable.vue : - Adding the name of the server where the match will be played - Adding a connect button - Fix the display of the team1 name wasn't show MatchInfo.vue - Adding a connect button with the name of the server you will join Translation.json - Adding multiple value in FR / EN relative to this update Fix : Using a relationship to show the right TeamName in place of using match.team1_string and match.team2_string to keep the information up-to-date
| match.start_time != null | ||
| ) { | ||
| matchString = `Live, ${team1Score}:${team2Score} vs ${match.team2_string}`; | ||
| matchString = `Live, ${team1Score}:${team2Score} - ${match.team1_string} vs ${match.team2_string}`; |
There was a problem hiding this comment.
Oh I see what you mean. This was a design choice since both teams are already showing in the table. So Team 1 is always considered the "Home" team, so this is why it was always vs Team2. I'm not opposed, but how does this look/feel on smaller screens or mobile layout?
There was a problem hiding this comment.
Like this from my browser with mobile compatiblity.
We can add a column with the teams instead of displaying these info in the status
| "Status": "Status", | ||
| "Server": "Serveur", | ||
| "Owner": "Propriétaire", | ||
| "ConnectButton": "Se connecter", |
There was a problem hiding this comment.
You can just DeepL in order to get the JP translations as well. Make sure it's included as well!
There was a problem hiding this comment.
English / French OK but i don't speak JP and can't maintain all the languages :/
I've updated the future translation.json
| </div> | ||
| </template> | ||
|
|
||
| <template v-slot:item.connect="{ item }"> |
There was a problem hiding this comment.
Maybe have a check only if the person is a super_admin/admin or is a part of the match to show the connect button. And maybe remove the button when the match is completed.
There was a problem hiding this comment.
I've add a v-if on the match.end_time to hide the connect and gotv button when the field isn't null.
Checking admin/superadmin not works actually, i've set my SteamID in the production.json, but no effect.
There was a problem hiding this comment.
I'm fairly certain that is a configuration issue. Please revert this change as it was working prior to by having the v-if on the template.
|
Also, please continue to use the match specifically, or have it choose the Team name if it is not a pug, or the team exists :) that way the API would not need to be changed as much, either. |
What is "pug" ? |
Hide Connect & GOTV button when match is terminated Adding JP values to previous modifications
Forget to translate "Forfeit Match"
Typo Fix
2 participants
MatchesTable.vue :
MatchInfo.vue
Translation.json
Fix : Using a relationship to show the right TeamName in place of using match.team1_string and match.team2_string to keeping the information up-to-date