-
Notifications
You must be signed in to change notification settings - Fork 47
Add Uplay option for Assassin's Creed I #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for the contribution. Have you tested the script? |
If you prefer rolling release, then i did. If you prefer stable release, then i did not. |
I don't understand |
Then i did not, will test |
Results in:
Suspecting it beeing issue with quick script. Found syntax err on line 12.. i hate java so much it can't even count correctly |
Does the game run? |
|
Testing: vcrun2005 is installed by uplay
Based on https://forums.tomshardware.com/threads/does-assassins-creed-work-on-windows-7-32bit.103522/ game supports 32-bit Relevant: https://pastebin.com/iJ1suWX3 |
Please run the game using a terminal (container tab->engine tool->open a terminal) to have the log too. |
Meh using system wine for testing, would use phoenicis if there was an option to get |
What does it ever means ? Also, since the script are done for phoenicis, you should test them as a regular phoenicis user. |
For me to test it as phoenicis user i have to use |
Why do you have to use such a command ?! I never do that. |
Trying to add vcrun2005 and d3d10 -> No effect |
So that it's using phoenicis instead of system? |
If you use Container->engine tools->open a terminal, the terminal will already have those var set and you are able to launch wine with |
ah didn't know that o.o ty |
@ImperatorS79 i think that this is issue on my end since DXVK is trying to load iGPU, can you test on your end? |
No, I cannot. |
Please post the wine log and the dxgi and dxvk log if any. |
You might need
|
Works now -> DXVK verb update is required |
Based on my few mins of gameplay game works no issue with said variable. Blocked by #982 and Ready to merge after. |
Please set this to draft. Obviously, you did not test the script but only the game with system Wine which is irrelevant for this pull request. If the pull request is not opened as draft or at least stating that the script is untested, everybody will normally assume that it can be merged. If we cannot rely on this, we will have to simply close the pull requests to avoid that untested scripts show up in the repository. This comment of course is applicable for any similar pull request. |
AC I script tested, working, ready to merge. It was expected from you to merge without test in testing so that they can be pushed further after, but i can make them working now and scripts are made based on my experience with all these games since it doesn't need any workarounds on my system..
97% of your repository are scripts that are not working, fixed Quick steam which still needs fix for starting the installation since users have to perform this manually now and fixed uplay which should work no issue. btw still recommends rolling release since you are forcing stable which results in shit code in master and slow updates. |
|
Sorry if I'm wrong but how does this match with
|
using system wine for testing to make phoenicis script to be tested after in phoenicis, because i didn't know that i can export variables from phoenicis since you dont have documentation that informs about it. |
So you installed with the script and then tested from command line with system Wine? This information should definitely be part of the pr description. I probably makes sense to mark the script as "testing" because of this. |
Tested it ON PHOENICIS did research on system wine. Depending on different system configuration there might be issues for which end-users can fill new issues since i'm not seting up unreliable VM to test them or making backend for multiple systems to test it. |
Attempt to work around rendering issues. As refferenced on PhoenicisOrg/scripts#978 uplay needs application settings on `winvista` for `upc.exe` and `UbisoftGameLauncher.exe` to avoid rendering issues (PhoenicisOrg/scripts#965 (comment)). Signed-off-by: Jacob Hrbek <[email protected]>
Attempt to work around rendering issues. As referenced on PhoenicisOrg/scripts#978 uplay needs application settings on `winvista` for `upc.exe` and `UbisoftGameLauncher.exe` to avoid rendering issues (PhoenicisOrg/scripts#965 (comment)). Signed-off-by: Jacob Hrbek <[email protected]>
Attempt to work around rendering issues. As referenced on PhoenicisOrg/scripts#978 uplay needs application settings on `winvista` for `upc.exe` and `UbisoftGameLauncher.exe` to avoid rendering issues (PhoenicisOrg/scripts#965 (comment)). Signed-off-by: Jacob Hrbek <[email protected]>
Attempt to work around rendering issues. As referenced on PhoenicisOrg/scripts#978 uplay needs application settings on `winvista` for `upc.exe` and `UbisoftGameLauncher.exe` to avoid rendering issues (PhoenicisOrg/scripts#965 (comment)). NOTICE: Outputs fatal error which is non-fatal, but i'm unable to stop it from appearing. Signed-off-by: Jacob Hrbek <[email protected]>
Attempt to work around rendering issues. As referenced on PhoenicisOrg/scripts#978 uplay needs application settings on `winvista` for `upc.exe` and `UbisoftGameLauncher.exe` to avoid rendering issues (PhoenicisOrg/scripts#965 (comment)). NOTICE: Outputs fatal error which is non-fatal, but i'm unable to stop it from appearing. Signed-off-by: Jacob Hrbek <[email protected]>
Attempt to work around rendering issues. As referenced on PhoenicisOrg/scripts#978 uplay needs application settings on `winvista` for `upc.exe` and `UbisoftGameLauncher.exe` to avoid rendering issues (PhoenicisOrg/scripts#965 (comment)). NOTICE: Outputs fatal error which is non-fatal, but i'm unable to stop it from appearing. Signed-off-by: Jacob Hrbek <[email protected]>
Attempt to work around rendering issues. As referenced on PhoenicisOrg/scripts#978 uplay needs application settings on `winvista` for `upc.exe` and `UbisoftGameLauncher.exe` to avoid rendering issues (PhoenicisOrg/scripts#965 (comment)). NOTICE: Outputs fatal error which is non-fatal, but i'm unable to stop it from appearing. Signed-off-by: Jacob Hrbek <[email protected]>
"id" : "applications.games.assassins_creed", | ||
"description" : "Assassin's Creed™ is the next-gen game developed by Ubisoft Montreal that redefines the action genre. While other games claim to be next-gen with impressive graphics and physics, Assassin's Creed merges technology, game design, theme and emotions into a world where you instigate chaos and become a vulnerable, yet powerful, agent of change.<br><br>The setting is 1191 AD. The Third Crusade is tearing the Holy Land apart. You, Altair, intend to stop the hostilities by suppressing both sides of the conflict.You are an Assassin, a warrior shrouded in secrecy and feared for your ruthlessness. Your actions can throw your immediate environment into chaos, and your existence will shape events during this pivotal moment in history." | ||
"description" : "Assassin's Creed is the next-gen game developed by Ubisoft Montreal that redefines the action genre. While other games claim to be next-gen with impressive graphics and physics, Assassin's Creed merges technology, game design, theme and emotions into a world where you instigate chaos and become a vulnerable, yet powerful, agent of change.<br><br>The setting is 1191 AD. The Third Crusade is tearing the Holy Land apart. You, Altair, intend to stop the hostilities by suppressing both sides of the conflict.You are an Assassin, a warrior shrouded in secrecy and feared for your ruthlessness. Your actions can throw your immediate environment into chaos, and your existence will shape events during this pivotal moment in history." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changed? As far as I can tell, only the "TM" has been removed. It doesn't make sense that we have to update all the translations just for this.
Credit: https://github.com/Haoose/UPLAY_GAME_ID/blob/master/README.md
Blocked by: #978Blocked by #982 and Ready to merge after.