Improve list design #169
Merged
Improve list design #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yling and animations - Updated the animation properties for the StrategiesTable component for smoother transitions. - Refactored the card styles in StrategiesTable to include a gradient background, hover effects, and improved layout. - Added a scrollbar customization for better visibility in the StrategiesTable. - Enhanced the StrategyEntry component with new styles, including a gradient background and hover effects. - Improved mobile layout for both StrategiesTable and StrategyEntry, ensuring better usability. - Added conditional rendering for displaying strategy counts and loading states. - Updated typography styles for better readability and visual hierarchy. - Refined the layout of strategy details, including TVL, APR, and user stake information.
- Updated TransactionsHeader component to improve hover effects and styling. - Refactored TransactionsTable to utilize new card styles and improve responsiveness. - Enhanced tab selection styles in VolumeChart for better user interaction. - Improved tooltip design in VolumeChart for clearer data presentation. - Adjusted spacing and layout across components for a more cohesive design.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR “Improve list design” introduces enhanced sorting options and layout refinements across both API and UI components. Key changes include:
- Adding sortBy and sortOrder properties to the AdvancedTradesParams and updating API calls accordingly.
- Refining UI components with updated spacing, typography, and motion animations in transactions, volume charts, and strategies lists.
- Updating filter and sort logic in history and transactions pages for improved maintainability and visual consistency.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/utils/src/trade_api/types.ts | Added sortBy and sortOrder fields to support API-level sorting |
| packages/utils/src/trade_api/trade_api.ts | Reformatted condition logic for improved readability |
| packages/utils/src/api/fetchTrades.ts | Propagated sort-related parameters through the API call |
| packages/ui/src/Transactions/VolumeChart/VolumeChart.tsx | Updated styling and motion effects for tab and chart container design |
| packages/ui/src/Transactions/TransactionsTable/TransactionsTable.tsx | Improved layout, animations, and typographic adjustments in transaction listing |
| packages/ui/src/Transactions/TransactionsTable/TransactionsHeader.tsx | Updated sort handling with a consistent mapping approach |
| packages/ui/src/Transactions/TransactionsTable/TransactionEntry.tsx | Added helper functions for formatting dates, amounts, and transaction hashes |
| packages/ui/src/Earn/StrategiesTable/StrategyEntry.tsx | Refactored UI layout and updated APR display, with modified calculation factor |
| packages/ui/src/Earn/StrategiesTable/StrategiesTable.tsx | Adjusted spacing, margins, and responsiveness in the strategies table |
| packages/ui/src/Earn/FilterBar/FilterBar.tsx | Overhauled filter UI styling and behavior with new theme variable usage |
| packages/core/app/pools/page.tsx | Updated layout margins and spacing for pool pages |
| packages/core/app/history/page.tsx | Separated volume chart timeframes and refined load/sort logic for history filtering |
Comments suppressed due to low confidence (2)
packages/ui/src/Earn/StrategiesTable/StrategyEntry.tsx:195
- It appears the APR is now displayed as half of the original value (i.e. divided by 2). Please confirm whether this change is intentional.
up to {((apr * 100)/2).toFixed(1)}%
packages/utils/src/trade_api/types.ts:73
- [nitpick] Consider adding inline documentation/comments for the new 'sortBy' and 'sortOrder' fields to clarify their intended usage and accepted values for future maintainability.
sortBy?: string; sortOrder?: "asc" | "desc";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.