Better check for ubuntu user in rubik image #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samfreund
force-pushed
the
deluser-ubuntu
branch
from
a0e0b90 to
3cc6bd3
Compare
mcm001
reviewed
Nov 11, 2025
|
|
||
| if id "ubuntu" >/dev/null 2>&1; then | ||
| cat /etc/passwd | ||
| if grep "ubuntu" /etc/passwd; then |
Contributor
There was a problem hiding this comment.
Will this work if not running as root? Does anyone run this as non root?
Member
Author
There was a problem hiding this comment.
It likely won't work if not run as root, we're the only ones who run this, for building the image, so it doesn't really matter.
Member
Author
|
Converting to a draft, the ubuntu user doesn't seem to exist here 🤔 |
samfreund
force-pushed
the
deluser-ubuntu
branch
from
3cc6bd3 to
a4ba5c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we checked using
id, which fails if we're running under a different user (such as root). We now check the/etc/passwdfile.