Skip to content

Reenable tests #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Reenable tests #1837

wants to merge 3 commits into from
+3 −8

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Mar 22, 2025

Description

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner March 22, 2025 04:55
@mcm001
Copy link
Contributor

mcm001 commented Mar 22, 2025

Descriptive!

@Gold856
Copy link
Contributor Author

Gold856 commented Mar 22, 2025

Whoops, I forgot to switch the repo to my fork.

@Gold856 Gold856 marked this pull request as draft March 22, 2025 05:56
@Gold856
Copy link
Contributor Author

Gold856 commented Mar 22, 2025

Well, at least we know which tests are failing. Seems to have gotten worse than when we disabled them.

@mcm001
Copy link
Contributor

mcm001 commented Mar 22, 2025

Yeah. It seems they have bitrotted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gold856 @mcm001