Update delete camera wording #1839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -222,7 +222,7 @@ const wrappedCameras = computed<SelectItem[]>(() => | |||
| <v-card-text> | |||
| <v-row class="align-center pt-6"> | |||
| <v-col cols="12" md="6"> | |||
| <span class="white--text"> This will delete ALL OF YOUR SETTINGS and restart PhotonVision. </span> | |||
| <span class="white--text"> This will delete all settings, including calibration data. Are you sure? </span> | |||
There was a problem hiding this comment.
There's also a backup settings button a bit down, could we change that to back up the calibrations?
There was a problem hiding this comment.
We can -- it would be more involved, and not really a kind of zip file people are familiar with. I'm worried having a "full settings zip" and "zip full of calibrations" is confusing
We could instead show a list of cal JSONs to export?
Or just, a hyperlink to the camera settings page?
There was a problem hiding this comment.
Either of those sound reasonable to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarify that deleting camera settings only deletes that camera's settings
Closes #1838
Meta
Merge checklist: