-
Notifications
You must be signed in to change notification settings - Fork 240
Migrate NNM Settings to SQLITE #1894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HARD BREAK LET'S GO |
Also if anyone feels like reviewing the backend stuff, that's pretty much done. |
photon-core/src/main/java/org/photonvision/common/configuration/LegacyConfigProvider.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkProperties.java
Outdated
Show resolved
Hide resolved
|
I got it loaded on my pi and seems functional in the basics. One UI flow question: When doing a bulk upload, after I select the zip, there's no UI response indicating the file is uploading or being unpacked (kinda like the .jar does) - I was worried that things had frozen for a decent bit. Also, once it reports "rebooting", the modal remains up with no obvious close button (probably should auto-close, and also have a cancel button or an X): Should change this to report progress - no freezing in place. |
Looks like this is not currently showing up at all on the Rubik Pi - I assume that's expected for now? |
Yup, as it's not currently supported. |
The code is there for it to autoclose, but I'm guessing because the system reboots, it's no longer checking if the properties have changed or not. We could try reloading the page after, but again, it might not actually happen given the system is rebooting. I believe this same behavior would be seen when using the settings import button, I'm going to go test that. |
3e96581
to
c7b9cf5
Compare
photon-core/src/main/java/org/photonvision/common/configuration/ConfigManager.java
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/configuration/LegacyConfigProvider.java
Show resolved
Hide resolved
...n-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkPropertyManager.java
Outdated
Show resolved
Hide resolved
photon-client/src/components/dashboard/tabs/ObjectDetectionTab.vue
Outdated
Show resolved
Hide resolved
photon-client/src/components/dashboard/tabs/ObjectDetectionTab.vue
Outdated
Show resolved
Hide resolved
photon-client/src/components/dashboard/tabs/ObjectDetectionTab.vue
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/configuration/ConfigManager.java
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/configuration/LegacyConfigProvider.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we ball
Co-authored-by: Gold856 <[email protected]> Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Gold856 <[email protected]> Co-authored-by: Chris Gerth <[email protected]>
Description
This migrates all the characteristics for neural network models to the sqlite database. The
.rknn
files themselves will stay in the file-system.Each model will have a resolution characteristic (width x height), list of labels, nickname, family (currently only RKNN, but other families might be PRed later), and version.
When selecting the option to upload a custom model, users will be prompted to provide the model file and resolution. Family will be determined based on the platform (RKNN for opi), and users will be prompted to select a version based on the the family. Nickname will be assigned to the name of the file initially, and can be changed in the UI.
When shipped with the jar, each model will have its characteristics hardcoded in NNMM.
Also deletes object detection tests as they only reference the name parsing. More tests will be implemented at a later date (see #1905).
closes #1748
Meta
Merge checklist: