Migrate NNM Settings to SQLITE #1894
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcm001 How do we want to handle importing object detection models from 2025? iirc all we had was the ability to export the |
|
Also if anyone feels like reviewing the backend stuff, that's pretty much done. |
mcm001
reviewed
Apr 16, 2025
| @Override | ||
| public boolean saveUploadedNeuralNetworkProperties(Path uploadPath) { | ||
| // TODO I'm not implementing this cause nobody with the legacy config is gonna have one of these | ||
| throw new UnsupportedOperationException( |
There was a problem hiding this comment.
I mean this exception may be caught. Nuclear option is to System.exit
| * family. A suggested solution is to add other version attributes, and the | ||
| * attribute for an unused version is to be left null. | ||
| */ | ||
| public class ModelProperties { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This migrates all the characteristics for neural network models to the sqlite database. The
.rknnfiles themselves will stay in the file-system.Each model will have a resolution characteristic (width x height), list of labels, nickname, family (currently only RKNN, but other families might be PRed later), and version.
When selecting the option to upload a custom model, users will be prompted to provide the model file and resolution. Family will be determined using file extension, and users will be prompted to select a version based on the the family. Nickname will be assigned to the name of the file initially, and can be changed in the UI.
When shipped with the jar, each model will have an accompanying json file listing its characteristics.
Also deletes object detection tests as they only reference the name parsing. More tests will be implemented at a later date (see #1905).
#1900 blocking cause I'm lazy and don't want to deal with merge conflicts on the front end.
Meta
Merge checklist: