remove legacy config #1904
Draft
remove legacy config #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
reviewed
Apr 15, 2025
| public static class LegacyCameraConfigStruct { | ||
| PVCameraInfo matchedCameraInfo; | ||
|
|
||
| /** Legacy constructor for compat with 2024.3.1 */ |
There was a problem hiding this comment.
We can't drop support for v2024.3.1 until after this year....
There was a problem hiding this comment.
Does that mean until 2026 season, or until the 2027 season.
mcm001
requested changes
Apr 15, 2025
Comment on lines
-598
to
-614
| if (config.matchedCameraInfo == null) { | ||
| logger.info("Legacy CameraConfiguration detected - upgrading"); | ||
|
|
||
| // manually create the matchedCameraInfo ourselves. Need to upgrade: | ||
| // baseName, path, otherPaths, cameraType, usbvid/pid -> matchedCameraInfo | ||
| config.matchedCameraInfo = | ||
| JacksonUtils.deserialize(configStr, LegacyCameraConfigStruct.class).matchedCameraInfo; | ||
|
|
||
| // Except that otherPaths used to be its own column. so hack that in here as well | ||
| var otherPaths = | ||
| JacksonUtils.deserialize( | ||
| result.getString(Columns.CAM_OTHERPATHS_JSON), String[].class); | ||
| if (config.matchedCameraInfo instanceof UsbCameraInfo usbInfo) { | ||
| usbInfo.otherPaths = otherPaths; | ||
| } | ||
| } | ||
|
|
|
also #1488 is related |
|
I need to update a test, but as this is blocked until after champs, it's not a priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removes the legacy config as it's no longer used. This breaks support for anyone who has settings saved from pre-2025.
Stalled until post champs
Meta
Merge checklist: