-
Notifications
You must be signed in to change notification settings - Fork 264
Exit and serve static html message on SystemCore #2170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
update stuff I missed
| } | ||
|
|
||
| // Exit | ||
| System.exit(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- you never call javelin.serve
- you must let javalin live to be a web server. You can't exit...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you never call javelin.serve
app = io.javalin.Javalin.create(cfg -> cfg.showJavalinBanner = false).start(port);This is functionally equivalent, it does the same thing and serves it.
you must let javalin live to be a web server. You can't exit...
We suspend the process, the exit is only there if something in the webserver fails.
616aa21 to
c2c8b13
Compare

Description
Needs to be tested on SC.
Running on SystemCore is bad, as PV tends to be a resource hog. Additionally, if issues arise, it can cause major problems. We want to ensure that a team has to intentionally take actions in order to run PV on SC, thus we serve a static webpage informing teams that SC isn't supported and exit.
Meta
Merge checklist: