-
Notifications
You must be signed in to change notification settings - Fork 264
Add playwright E2E tests #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samfreund
wants to merge
25
commits into
PhotonVision:main
Choose a base branch
from
samfreund:playwright
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add playwright E2E tests #2174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37df36e to
b4fbbc9
Compare
5037510 to
aa5887e
Compare
192b96c to
a2d2413
Compare
5508750 to
9ff1563
Compare
0c255c3 to
c207b4a
Compare
Collaborator
|
Can we avoid data-testid? I don't like adding test-only things to code (although we are already doing that on the server). I would slightly prefer it if we could locate the elements in a different way. |
c207b4a to
7c250cd
Compare
clean up workflow
rework backend for platform override
export test root path
7c250cd to
ac62d08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds playwright tests. These will test the frontend and the backend, by running both of them and simulating interactions with the frontend.
Meta
Merge checklist: