Skip to content

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Nov 2, 2025

Description

This adds playwright tests. These will test the frontend and the backend, by running both of them and simulating interactions with the frontend.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Nov 2, 2025
@samfreund samfreund force-pushed the playwright branch 3 times, most recently from 37df36e to b4fbbc9 Compare November 2, 2025 00:20
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Nov 2, 2025
@samfreund samfreund force-pushed the playwright branch 10 times, most recently from 5037510 to aa5887e Compare November 2, 2025 05:31
@github-actions github-actions bot removed the backend Things relating to photon-core and photon-server label Nov 2, 2025
@samfreund samfreund force-pushed the playwright branch 2 times, most recently from 192b96c to a2d2413 Compare November 2, 2025 06:58
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Nov 2, 2025
@samfreund samfreund force-pushed the playwright branch 5 times, most recently from 5508750 to 9ff1563 Compare November 2, 2025 20:40
@samfreund samfreund marked this pull request as ready for review November 2, 2025 20:40
@samfreund samfreund requested a review from a team as a code owner November 2, 2025 20:40
@samfreund samfreund force-pushed the playwright branch 2 times, most recently from 0c255c3 to c207b4a Compare November 2, 2025 21:17
@samfreund samfreund moved this from Backlog to In review in Frontend Testing Implementation Nov 2, 2025
@samfreund samfreund self-assigned this Nov 2, 2025
@Gold856
Copy link
Collaborator

Gold856 commented Nov 8, 2025

Can we avoid data-testid? I don't like adding test-only things to code (although we are already doing that on the server). I would slightly prefer it if we could locate the elements in a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server frontend Having to do with PhotonClient and its related items

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants