Make HOME and DATASETS filesystem paths configurable via env vars#1
Open
Make HOME and DATASETS filesystem paths configurable via env vars#1
Conversation
photoroman
approved these changes
Mar 16, 2026
Contributor
photoroman
left a comment
photoroman
left a comment
There was a problem hiding this comment.
LGTM. Suggestion is optional.
| collect_local_filesystem("/home"), | ||
| collect_local_filesystem("/mnt/data"), | ||
| collect_local_filesystem(&home_path), | ||
| collect_local_filesystem(&datasets_path), |
Contributor
There was a problem hiding this comment.
Should we maybe call the env vars CTOP_MONITORED_FOLDER1 and CTOP_MONITORED_FOLDER2 to make it truly generic, i.e. for other clusters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The paths used to collect local filesystem usage were hardcoded to
/homeand
/mnt/data. These are now read from environment variables at runtime.Changes:
$HOMEcontrols the home filesystem path (fallback:/home)$DATASETScontrols the datasets filesystem path (fallback:/mnt/data)Usage:
DATASETS=/mnt/datasets ctop
Note: if a collector is already running, stop it first:
ctop --stop-collector