handle KeyError error when getting security prices #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to fix:
Exception on /beancount/extension/PortfolioSummary/ [GET]
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/fava_portfolio_summary/__init__.py", line 71, in portfolio_accounts
portfolio = self._account_metadata_pattern(tree, key, pattern, internal, mwr, twr)
File "/usr/local/lib/python3.10/site-packages/fava_portfolio_summary/__init__.py", line 172, in _account_metadata_pattern
portfolio_data = self._portfolio_data(selected_accounts, internal, mwr, twr)
File "/usr/local/lib/python3.10/site-packages/fava_portfolio_summary/__init__.py", line 263, in _portfolio_data
rows.append(total)
File "/usr/local/lib/python3.10/site-packages/fava_portfolio_summary/__init__.py", line 233, in _process_node
try:
File "/usr/local/lib/python3.10/site-packages/fava/core/__init__.py", line 538, in prices
all_prices = get_all_prices(self.price_map, (base, quote))
File "/usr/local/lib/python3.10/site-packages/beancount/core/prices.py", line 303, in get_all_prices
return _lookup_price_and_inverse(price_map, base_quote)
File "/usr/local/lib/python3.10/site-packages/beancount/core/prices.py", line 278, in _lookup_price_and_inverse
return price_map[base_quote]
KeyError: ('CHF', 'VT')
Owner
|
I don't love this work-around. I'll look into finding a more-robust answer to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered following error when using the extension:
The problem for me is that I have securities which are traded in USD, while my operating currency is CHF. It seems operating currency does not work in the situation where the user needs to trade uisng different currencies. I propose to add this workaround for the time being and later work on a smarter solution to figure out which currency should be used to obtain the prices.