fix(client): clip float images before convert_to_uint8#994
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
Out-of-range float pixels previously wrapped when cast to uint8 (e.g. 1.5 → 127 after 255*x truncate). Clip to [0, 1] first.
Bartok9
requested review from
Michael-Equi,
jimmyt857 and
kvablack
as code owners
July 10, 2026 22:57
jimmyt857
removed their request for review
July 11, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convert_to_uint8scaled float images by 255 then cast touint8with no clipping. Values outside[0, 1]wrap (C-style cast), producing garbage pixels on the wire / for model input.Changes
np.clip(img, 0.0, 1.0)before scaleVerification
New unit tests in
image_tools_test.py.Duplicate check
No open PR for this clip behavior.