fix(scripts): single-device sharding for compute_norm_stats torch path#999
Open
Bartok9 wants to merge 1 commit into
Open
fix(scripts): single-device sharding for compute_norm_stats torch path#999Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Salvage of Physical-Intelligence#438 by @tlpss — rebased to main. Size-1 batches cannot shard across multi-GPU meshes; pin SingleDeviceSharding for norm-stats collection convenience.
jimmyt857
removed their request for review
July 11, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jax.sharding.SingleDeviceSharding(jax.devices()[0])intoTorchDataLoaderwhen computing norm stats.Motivation
On multi-GPU hosts, default mesh sharding cannot split
batch_size=1stats batches. Users previously had to setCUDA_VISIBLE_DEVICES.Salvage of #438 by @tlpss — rebased to main (file structure now uses
create_torch_dataloaderhelpers).Verification
TorchDataLoaderalready accepts optionalsharding=shuffle=Falsealready)Attribution
Salvage of #438 by @tlpss — rebased to main