[Fix] Fix address uniqueness to use IO Type and address - #484
Merged
Conversation
Refactored `Registry` to use `IOType` for managing addresses, ensuring better segregation of address spaces between IO types. Updated related methods and internal data structures accordingly.
FDelporte
reviewed
Sep 5, 2025
| @Override | ||
| public synchronized boolean exists(int address) { | ||
| return usedAddresses.contains(address); | ||
| public synchronized boolean exists(IOType ioType, int address) { |
FDelporte
approved these changes
Sep 5, 2025
Introduced the ability to shutdown and unregister IO instances using the instance itself, complementing the existing ID-based method. Updated related methods, tests, and documentation to reflect the new functionality.
Member
Author
|
@FDelporte i added tests |
Member
|
Member
or not? ;-) |
…tRuntimeRegistry`
…d `@AfterEach` in `RegistryTest` for better test isolation.
Member
Author
|
There was an issue with tests not cleaned up between each run. Is fixed now. |
Member
Author
|
@taartspi @FDelporte can we merge? |
Member
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issue where a PWM and GPIO use the same address as integer, but should be possible as they are different I/Os.