try fixing clang-tidy

Author: henrygerardmoore

Diff for: .github/workflows/ci.yaml

@@ -93,7 +93,8 @@ jobs:
             **.cpp
             **.hpp
       - if: ${{ steps.changed-cpp-files.outputs.all_changed_files != '' }}
-        run: run-clang-tidy -j $(nproc --all) -p build/ -export-fixes clang-tidy-fixes.yaml -config "$(cat src/fuse/.clang-tidy)" ${{ steps.changed-cpp-files.outputs.all_changed_files }}
+        # https://stackoverflow.com/questions/48404289/using-clang-tidy-to-check-c17-code
+        run: run-clang-tidy -j $(nproc --all) -p build/ -export-fixes clang-tidy-fixes.yaml -config "$(cat src/fuse/.clang-tidy)" -extra-arg=-std=c++17 ${{ steps.changed-cpp-files.outputs.all_changed_files }}
         working-directory: /colcon_ws
       - uses: asarium/[email protected]
         with:

Diff for: fuse_models/src/unicycle_2d_ignition.cpp

@@ -268,8 +268,8 @@ void Unicycle2DIgnition::process(const geometry_msgs::msg::PoseWithCovarianceSta
     // It needs to be free to handle the response to this service call.
     // Have a callback do the rest of the work when a response comes.
     auto result_future = reset_client_->async_send_request(
-        srv, [this, post_process, pose](rclcpp::Client<std_srvs::srv::Empty>::SharedFuture result) {
-          (void)result;
+        // NOLINTNEXTLINE(performance-unnecessary-value-param)
+        srv, [this, post_process, pose](rclcpp::Client<std_srvs::srv::Empty>::SharedFuture /*result*/) {
           // Now that the pose has been validated and the optimizer has been reset, actually send the
           // initial state constraints to the optimizer
           sendPrior(pose);

Diff for: run_clang_tidy.bash

@@ -1,4 +1,4 @@
 #!/bin/bash
 
 # -j $(nproc --all) runs with all cores, but the prepended nice runs with a low priority so it won't make your computer unusable while clang tidy is going. The "$@" at the end passes all the filenames from pre-commit so it should only look for clang tidy fixes in the files you directly changed in the commit that is being checked.
-nice run-clang-tidy -p ../../build_dbg -j $(nproc --all) -quiet -fix "$@"
+nice run-clang-tidy -p ../../build_dbg -j $(nproc --all) -quiet -fix -extra-arg=-std=c++17 "$@"