Introduce AssertThatHasValue Refaster rule

[JulianBroudy]

Refaster:

assertThat(optional.orElseThrow()).isEqualTo(value);

to:

assertThat(optional).hasValue(value);

Suggested Commit Message 🎉

Introduce `AssertThatHasValue` Refaster rule (#1547)

[rickie]

Ahh nice that you opened the PR 🚀 !

We can probably add one case to the Refaster rule above here AbstractOptionalAssertHasValue.

The build will probably fail as we also need to add tests 😄. Try running mvn clean install to see whether the build passes 😉.

[JulianBroudy]

We can probably add one case to the Refaster rule above here AbstractOptionalAssertHasValue.

Maybe we can go over it together? Because IIUC we cannot add the following:

If we stay with the new function, should it maybe also return AbstractAssert<?, ?> instead of ObjectAssert<T>?

The build will probably fail as we also need to add tests 😄. Try running mvn clean install to see whether the build passes 😉.

On it!

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Stephan202]

Congrats on your first contribution, @JulianBroudy! 🎉 Too bad this is a tricky one. 😬

I rebased and added a commit to show the issue. Normally for this kind of change we would use this commit message:

Introduce `AssertThatHasValue` Refaster rule (#1547)

But as this approach won't work, we'll have to consider an alternative: introducing an AssertThatHasValue Error Prone checker, just like we did for AssertJIsNull. This variant would be slightly more complex, but not by much. Are you up for that? I'm sure @rickie is up for providing some pointers :)

[Stephan202]

As-is, this rule will only match Optional<String> assertions, while we would like to match any Optional<T> assertion:

Suggested change

	AbstractStringAssert<?> before(Optional<String> optional, String value) {
	ObjectAssert<T> before(Optional<T> optional, T value) {

... but then we find that the tests fails, because of how Refaster works: the rule will only match the used assertThat overload, while there are many.

[JulianBroudy]

Thanks @Stephan202, always up for anything!

We started with having it as generic and then went on to making it specific for each of String, Boolean, etc. Finally decided to stay only with String for now. I will take another look with @rickie.