-
Notifications
You must be signed in to change notification settings - Fork 41
Upgrade JDKs used by GitHub Actions builds #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Looks good. No mutations were possible for these changes. |
The build isn't yet JDK 24-compatible, IIUC because OpenRewrite uses Lombok, while the used version of Lombok isn't compatible with JDK 24: projectlombok/lombok#3772. CC @timtebeek. NB: The referenced OpenRewrite code seems to treat Lombok as an optional dependency, but as we don't otherwise depend on Lombok, should this code path be taken at all? 🤔 |
It looks like the folks at Lombok are working on a release right now, based the comments here:
Once that's available from Maven Central I think it should be easy for us to put out a new patch release using that particular version, if needed. |
9343607
to
476b7ff
Compare
Looks good. No mutations were possible for these changes. |
476b7ff
to
65e0abd
Compare
Looks good. No mutations were possible for these changes. |
The build now fails due to openrewrite/rewrite-templating#118 / openrewrite/rewrite#4768; the top-level issue to track is openrewrite/rewrite#5211. |
Summary of changes: - Use JDK 17.0.14 instead of 17.0.13. - Use JDK 21.0.6 instead of 21.0.5. - Use JDK 24 instead of 23.0.1. - Have GitHub issue template reference more recent version numbers. See: - https://adoptium.net/temurin/release-notes/?version=jdk-17.0.14+7 - https://adoptium.net/temurin/release-notes/?version=jdk-21.0.6+7 - https://adoptium.net/temurin/release-notes/?version=jdk-24+36
65e0abd
to
a2cb17f
Compare
Looks good. No mutations were possible for these changes. |
|
Bumped JDK versions; new release notes not yet available. |
Java 24 support has been merged on our side and will go out early next week in a new release. |
Suggested commit message: