Skip to content

Upgrade JDKs used by GitHub Actions builds #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Mar 22, 2025

Suggested commit message:

Upgrade JDKs used by GitHub Actions builds (#1609)

Summary of changes:
- Use JDK 17.0.15 instead of 17.0.13.
- Use JDK 21.0.7 instead of 21.0.5.
- Use JDK 24.0.1 instead of 23.0.1.
- Have GitHub issue template reference more recent version numbers.

See:
- https://adoptium.net/temurin/release-notes/?version=jdk-17.0.14+7
- https://adoptium.net/temurin/release-notes/?version=jdk-17.0.15+6
- https://adoptium.net/temurin/release-notes/?version=jdk-21.0.6+7
- https://adoptium.net/temurin/release-notes/?version=jdk-21.0.7+6
- https://adoptium.net/temurin/release-notes/?version=jdk-24+36
- https://adoptium.net/temurin/release-notes/?version=jdk-24.0.1+9

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member Author

The build isn't yet JDK 24-compatible, IIUC because OpenRewrite uses Lombok, while the used version of Lombok isn't compatible with JDK 24: projectlombok/lombok#3772.

CC @timtebeek.

NB: The referenced OpenRewrite code seems to treat Lombok as an optional dependency, but as we don't otherwise depend on Lombok, should this code path be taken at all? 🤔

@timtebeek
Copy link
Contributor

It looks like the folks at Lombok are working on a release right now, based the comments here:

Once that's available from Maven Central I think it should be easy for us to put out a new patch release using that particular version, if needed.

@rickie rickie force-pushed the sschroevers/upgrade-gha-jdks branch from 9343607 to 476b7ff Compare April 12, 2025 08:20
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the sschroevers/upgrade-gha-jdks branch from 476b7ff to 65e0abd Compare April 12, 2025 08:42
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member Author

The build now fails due to openrewrite/rewrite-templating#118 / openrewrite/rewrite#4768; the top-level issue to track is openrewrite/rewrite#5211.

Summary of changes:
- Use JDK 17.0.14 instead of 17.0.13.
- Use JDK 21.0.6 instead of 21.0.5.
- Use JDK 24 instead of 23.0.1.
- Have GitHub issue template reference more recent version numbers.

See:
- https://adoptium.net/temurin/release-notes/?version=jdk-17.0.14+7
- https://adoptium.net/temurin/release-notes/?version=jdk-21.0.6+7
- https://adoptium.net/temurin/release-notes/?version=jdk-24+36
@Stephan202 Stephan202 force-pushed the sschroevers/upgrade-gha-jdks branch from 65e0abd to a2cb17f Compare April 18, 2025 17:35
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member Author

Bumped JDK versions; new release notes not yet available.

@timtebeek
Copy link
Contributor

Java 24 support has been merged on our side and will go out early next week in a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants