Introduce SpringTestRules Refaster rule collection
#1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
force-pushed
the
sschroevers/introduce-SpringTestRules
branch
from
cd0fb91 to
6c8f11f
Compare
|
Looks good. No mutations were possible for these changes. |
|
Badbond
reviewed
Mar 31, 2025
Comment on lines
+27
to
+29
| BodyContentSpec after(BodyContentSpec spec, String expectedJson) { | ||
| return spec.json(expectedJson, JsonCompareMode.LENIENT); | ||
| } |
There was a problem hiding this comment.
Alternative to write it to the overload that does this by default:
Suggested change
| BodyContentSpec after(BodyContentSpec spec, String expectedJson) { | |
| return spec.json(expectedJson, JsonCompareMode.LENIENT); | |
| } | |
| BodyContentSpec after(BodyContentSpec spec, String expectedJson) { | |
| return spec.json(expectedJson); | |
| } |
There was a problem hiding this comment.
That's up for debate, indeed. As the Javadoc indicates, personally I feel this is a case where it's better to be explicit, because the default behavior is IMHO surprising / less strict than I'd have assumed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message:
Opening this as a draft PR, because I can't get the build to pass: despite the
@SuppressWarnings("deprecation")annotations, warnings are emitted, in duplicate. I suspect that there's an interesting interaction with the annotation processors/compiler plugins, but that's TBD.