-
Notifications
You must be signed in to change notification settings - Fork 49
Tweak AbstractMatcherTestChecker
#2050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Suggested commit message: |
|
Looks good. No mutations were possible for these changes. |
mohamedsamehsalah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ✅
5770e8f to
7d323d3
Compare
|
Looks good. No mutations were possible for these changes. |
Refaster template parameters will never match only the identifier of a method's receiver parameter, so for the purpose of testing `@Matches` and `@NotMatches` predicate classes, there's no need to descend into `VariableTree#getNameExpression()`. See https://docs.oracle.com/javase/specs/jls/se21/html/jls-8.html#jls-8.4
7d323d3 to
2ec8eb6
Compare
|
Looks good. No mutations were possible for these changes. |
|



Suggested commit message:
@rickie we discussed this offline. I don't think this is relevant to #261, though.