Skip to content

Conversation

@Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Jan 3, 2026

Suggested commit message:

Tweak `AbstractMatcherTestChecker` (#2050)

Refaster template parameters will never match only the identifier of a
method's receiver parameter, so for the purpose of testing `@Matches`
and `@NotMatches` predicate classes, there's no need to descend into
`VariableTree#getNameExpression()`.

See https://docs.oracle.com/javase/specs/jls/se21/html/jls-8.html#jls-8.4

@rickie we discussed this offline. I don't think this is relevant to #261, though.

@Stephan202 Stephan202 added this to the 0.28.0 milestone Jan 3, 2026
@Stephan202 Stephan202 added the chore A task not related to code (build, formatting, process, ...) label Jan 3, 2026
@github-actions
Copy link

github-actions bot commented Jan 3, 2026

Suggested commit message:

Tweak `AbstractMatcherTestChecker` (#2050)

Refaster template parameters will never match only the identifier of a
method's receiver parameter, so for the purpose of testing `@Matches`
and `@NotMatches` predicate classes, there's no need to descend into
`VariableTree#getNameExpression()`.

See https://docs.oracle.com/javase/specs/jls/se21/html/jls-8.html#jls-8.4

@github-actions
Copy link

github-actions bot commented Jan 3, 2026

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✅

@rickie rickie force-pushed the sschroevers/tweak-AbstractMatcherTestChecker branch from 5770e8f to 7d323d3 Compare January 5, 2026 08:27
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Refaster template parameters will never match only the identifier of a
method's receiver parameter, so for the purpose of testing `@Matches`
and `@NotMatches` predicate classes, there's no need to descend into
`VariableTree#getNameExpression()`.

See https://docs.oracle.com/javase/specs/jls/se21/html/jls-8.html#jls-8.4
@Stephan202 Stephan202 force-pushed the sschroevers/tweak-AbstractMatcherTestChecker branch from 7d323d3 to 2ec8eb6 Compare January 5, 2026 09:01
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2026

@rickie rickie merged commit eeed6d5 into master Jan 5, 2026
19 checks passed
@rickie rickie deleted the sschroevers/tweak-AbstractMatcherTestChecker branch January 5, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A task not related to code (build, formatting, process, ...)

Development

Successfully merging this pull request may close these issues.

4 participants