-
Notifications
You must be signed in to change notification settings - Fork 0
[PC-1666] 맛보기 매칭이슈, 퍼즐 조회 이슈 해결 #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughRemoved automatic puzzle count fetch from startup; converted Changes
Sequence Diagram(s)(omitted — changes are incremental UI/state updates and API threading, not a new multi-component control flow) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다.
카드 순서 관련해서 이슈 올라왔는데 확인하고 해당 브랜치에서 고쳐주세요
| internal fun fetchPuzzleCount() = viewModelScope.launch(dispatcher) { | ||
|
|
||
| if (currentState.userRole != UserRole.USER) return@launch | ||
| internal suspend fun fetchPuzzleCount() = suspendRunCatching { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viewmodel에서만 사용하면 private해도 될 거 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5dc2cf0 수정했습니다~
1. ⭐️ 변경된 내용
2. 🖼️ 스크린샷(선택)
3. 💡 알게된 부분
4. 📌 이 부분은 꼭 봐주세요!
Summary by CodeRabbit
Performance Improvements
New Features / UI
✏️ Tip: You can customize this high-level summary in your review settings.