Conversation
Author
|
https://github.com/billdizl/android-youtube-player/tree/dev_fix this link, i merge Fix leak And No WebView installed |
Author
|
This PR has already been used in the project Screen_recording_20231205_164122.mp4 |
Owner
|
Thank you for the PR, I will take a look during the Christmas holidays. |
Author
okay,Looking forward to good news for this pr. |
|
Could we check ? @PierfrancescoSoffritti |
Owner
|
The change is confusing, I am not sure what this is fixing. Some of the changes seem unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix leak #1083
@PierfrancescoSoffritti I try fix this leak success, i use this fix lib in my app , it not find any leak, u can look it . if it work ok , u can pr it. thanks