-
Notifications
You must be signed in to change notification settings - Fork 1
Feat(extension): 익스텐션 ui 반영 및 바운더리 최적화 작업 #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e0fe1f1
feat: 헤더 ui 수정
jllee000 94d7cc0
feat: 불필요 창닫기 기능 제거
jllee000 7c9f12b
feat: 익스텐션 헤더 호버 작용 추가
jllee000 82abbab
chore: 머지 에러 수정
jllee000 3f3bde4
feat: 헤더 컴포넌트 분리 및 랜딩 추가
jllee000 5f47f65
Merge remote-tracking branch 'origin/develop' into feat/#212/extensio…
jllee000 dacf9e3
feat: 로그아웃 팝업 창 작엉ㅂ
jllee000 117df60
feat: 팝업 노출 전 주석 처리
jllee000 0209008
chore: 에러 아이콘 삭제
jllee000 3ae69de
fix: 아이콘 추가 재빌드
jllee000 20927b2
feat: 익스텐션 토큰 존재 분기 뷰
jllee000 f7d0101
feat: 시맨틱 태그 변경
jllee000 4eacb64
Merge branch 'develop' into feat/#212/extension-optimization
jllee000 41c5de9
feat: 온보딩 패딩 수정
jllee000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { Icon } from '@pinback/design-system/icons'; | ||
|
|
||
| const LogOutPop = () => { | ||
| return ( | ||
| <div className="bg-white-bg common-shadow flex h-[35.5rem] w-[31.2rem] flex-col items-center justify-center rounded-[1.2rem] px-[3.2rem] py-[2.4rem]"> | ||
| <div className="mr-auto"> | ||
| <Icon name="main_logo" width={72} height={20} /> | ||
| </div> | ||
| <div className="flex items-center justify-center pb-[1rem] pt-[0.8rem] text-center"> | ||
| <Icon name="logout_chippi.2512" width={132} height={132} /> | ||
| </div> | ||
| <p className="sub2-sb mb-[0.4rem] text-black"> | ||
| 치삐를 만나려면 로그인이 필요해요! | ||
| </p> | ||
| <p className="body4-r text-font-gray-3 px-[4.15rem] text-center"> | ||
| 지금 로그인하고 북마크한 정보의 | ||
| <br /> 리마인드 알람을 받아보세요 | ||
| </p> | ||
| <button | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. button은 type 명시적으로 지정해주세요! |
||
| className="sub4-sb mt-[1.6rem] flex h-[4.4rem] w-[25.15rem] items-center justify-between rounded-full border border-gray-100 bg-white px-[2rem]" | ||
| type="button" | ||
| onClick={() => { | ||
| chrome.tabs.create({ | ||
| url: 'https://www.pinback.today/onboarding?step=SOCIAL_LOGIN', | ||
| }); | ||
| }} | ||
| > | ||
| <Icon name="google" width={21} height={21} /> | ||
| 구글 계정으로 로그인/회원가입 | ||
| </button> | ||
| </div> | ||
| ); | ||
| }; | ||
| export default LogOutPop; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { Icon } from '@pinback/design-system/icons'; | ||
| import { useState } from 'react'; | ||
| const Header = () => { | ||
| const [isHover, setIsHover] = useState(false); | ||
| return ( | ||
| <header className="flex items-center justify-between"> | ||
| <Icon | ||
| name={isHover ? 'ext_home2' : 'ext_home1'} | ||
| width={28} | ||
| height={28} | ||
| className="cursor-pointer" | ||
| onMouseEnter={() => setIsHover(true)} | ||
| onMouseLeave={() => setIsHover(false)} | ||
| onClick={() => { | ||
| chrome.tabs.create({ url: 'https://www.pinback.today/' }); | ||
| }} | ||
| /> | ||
| <Icon name="main_logo" width={72} height={20} /> | ||
| </header> | ||
| ); | ||
| }; | ||
|
|
||
| export default Header; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 툴팁 이미지 변경된거같은데 이부분은 파일 뺴고 올려주실 수 있나요? |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
토큰 확인 전 로딩 상태 처리 필요
isToken이null(초기값)일 때 falsy로 평가되어LogOutPop이 렌더링됩니다. 이로 인해 로그인된 사용자도 토큰 확인이 완료되기 전까지 잠깐 로그아웃 화면을 보게 됩니다.로딩 상태를 명시적으로 처리하는 것을 권장합니다:
🔎 수정 제안
Also applies to: 39-50
🤖 Prompt for AI Agents