refactor(tibuild): pretty the code

[wuhuizuo]

Signed-off-by: wuhuizuo [email protected]

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wuhuizuo, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• tibuild/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

The pull request seems to be a code refactoring that adds the github.com/deckarep/golang-set/v2 package to the go.mod file. It also renames the model.go file to types.go and updates the related imports. There are no potential problems related to these changes.

However, there are some issues with the code in dev_build_service.go that the pull request did not address. Specifically, there is an incorrect check for the edition field in the validateReq function. Instead of checking if the edition is valid against the ProductEdition type, it is checking if it is contained within a golang-set object. This could result in unexpected behavior if an invalid edition is passed in.

To fix this issue, the validateReq function should check if the edition is valid against the ProductEdition type. It could be done like this:

if !spec.Edition.IsValid() {
    return fmt.Errorf("edition is not valid")
}

In addition, since the ProductEdition type is not used in the code, it could be removed to simplify the codebase.

[ti-chi-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-scan-deps	93a5cd7	link	true	/test pull-scan-deps

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.