Skip to content

Add test for plan cache #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: unifytestframework
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions framework/certchecker.go
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
package framework

import (
"strings"

"github.com/PingCAP-QE/schrddl/pinolo/stage2"
"github.com/PingCAP-QE/schrddl/util"
"github.com/pingcap/errors"
"github.com/pingcap/tidb/pkg/util/logutil"
"go.uber.org/zap"
"strings"
)

type certChecker struct {
Expand Down Expand Up @@ -42,7 +44,7 @@ func (n *certChecker) check(sql string, isReduce bool) (ok bool, err error) {
rs1, err := n.c.execQueryForPlanEstCnt(querySQL)
//println(fmt.Sprintf("%s;", querySQL))
if err != nil {
if dmlIgnoreError(err) {
if util.DMLIgnoreError(err) {
return false, nil
} else {
logutil.BgLogger().Error("unexpected error", zap.String("query", querySQL), zap.Error(err))
Expand Down Expand Up @@ -81,7 +83,7 @@ func (n *certChecker) check(sql string, isReduce bool) (ok bool, err error) {

rs2, err := n.c.execQueryForPlanEstCnt(r.Sql)
if err != nil {
if dmlIgnoreError(err) {
if util.DMLIgnoreError(err) {
//logutil.BgLogger().Warn("ignore error", zap.String("query", r.Sql), zap.Error(err))
return false, nil
} else {
Expand Down
Loading