Commercial#1
Closed
PinkGranite wants to merge 7 commits into
Closed
Conversation
added 7 commits
April 19, 2026 14:00
…peline EasyPaper already carried auto-generation intent in FigureSpec, but the runtime skipped those figures instead of turning them into ordinary file-backed assets. This rewires that path so AcademicDreamer can materialize opted-in figures before validation and compilation, while the existing figure pipeline remains the single downstream path. Constraint: AcademicDreamer remains an optional external dependency and must not break base installs Constraint: Generated figures must normalize into file_path/materials_root semantics used by existing compilation paths Rejected: Nested generation config on FigureSpec | premature abstraction for a single path-first backend Rejected: Dynamic in-writing figure generation | violates confirmed preprocessing-only scope and complicates failure handling Confidence: high Scope-risk: moderate Reversibility: clean Directive: Preserve the preprocess-before-validate contract for auto-generated figures; do not move path validation ahead of materialization without reworking the generated-asset flow Tested: Targeted pytest for schema, preprocessing, run-script, and integration coverage (24 passed, 1 skipped) Not-tested: Task-3 documentation/review lane was blocked by worker account/runtime limits during team execution
EasyPaper already had the configured model credentials for its own agents, but the AcademicDreamer preprocessing path still required separate env setup. This routes the active configured key into real figure generation and adds a manual verification harness for inspecting normalized metadata and generated image outputs outside the normal test routine. Constraint: AcademicDreamer still consumes credentials through its existing env boundary Constraint: Manual real-generation verification must remain outside the standard pytest routine Rejected: Re-read YAML config inside figure_generation | duplicates config ownership and bypasses active agent configuration Rejected: Require users to configure the same key twice | unnecessary friction when EasyPaper already has the key Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep credential propagation tied to the active agent/client configuration and never serialize secrets into repository artifacts or commit messages Tested: Targeted pytest for figure generation preprocessing, run-script, and integration coverage (21 passed, 1 skipped); manual real generation check against a copied BLIP-2 metadata sample Not-tested: Broader full-repo suite; standalone AcademicDreamer CLI outside EasyPaper runtime
…ragraph - Consolidate four conclusion elements into one flowing narrative - Remove multi-paragraph structure from conclusion template - Enforce single paragraph constraint with hard constraint - Remove citations and cross-references from conclusion section
…on planning For AI-targeted venues (CVPR, NeurIPS, ICML, ICLR, AAAI, etc.), the planner now considers adding a summary paragraph (role="conclusion") at the end of Introduction that highlights main contributions and provides a roadmap to the paper structure. Added guidance to both paragraph planning functions: - _plan_flat_paragraphs (for sections without subsections) - _plan_subsection_paragraphs (for sections with subsections) Uses non-invasive "consider" language to guide rather than enforce.
…ormat guidance - Add contributions parameter to _plan_flat_paragraphs and _plan_subsection_paragraphs - Include actual contributions data in prompt for AI-targeted venues - Update guidance to specify bullet point format (e.g., "• We propose...") - Pass plan_data.contributions at both call sites
…ductions - Add venue parameter to _plan_flat_paragraphs for venue-specific guidance - For AI venues (CVPR, NeurIPS, ICML, ICLR, AAAI), Introduction follows 4-paragraph arc: Context → Gap → Approach → Contributions - Remove word-budget-driven paragraph count (approx_paragraphs calculation) - Word budget is now soft guideline; content structure determines paragraphs - Add contribution bullet point format guidance for conclusion paragraph - Pass style_guide as venue when calling _plan_flat_paragraphs Closes venue-aware introduction structure issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.2.1