Skip to content

Conversation

luancazarine
Copy link
Collaborator

@luancazarine luancazarine commented Oct 9, 2025

Resolves #11226

Summary by CodeRabbit

  • New Features
    • Adds a read-only hint to the Merge RSS Feeds action, improving clarity in the UI.
  • Improvements
    • Enhances RSS feed fetching reliability by sending a clearer User-Agent header during requests.
  • Chores
    • Bumps RSS component version to 0.5.10.
    • Updates action/source versions:
      • Merge RSS Feeds: 1.2.10
      • New Item from Multiple Feeds: 1.2.9
      • New Item in Feed: 1.2.9
      • Random Item in Multiple Feeds: 0.2.9
    • Internal import and linting cleanups (no user-visible changes).

- Bump @pipedream/rss version to 0.5.9
- Update merge-rss-feeds action version to 1.2.9
- Add User-Agent header in rss.app.ts
- Bump new-item-from-multiple-feeds source version to 1.2.8
- Bump new-item-in-feed source version to 1.2.8
…nings

- Added eslint-disable comments for explicit any type in itemTs, itemKey, fetchFeed, isJSONFeed, and sortItems methods in rss.app.ts.
- Updated new-item-from-multiple-feeds source to disable explicit any warning in forEach method.
- Bump @pipedream/rss version to 0.5.10
- Update merge-rss-feeds action version to 1.2.10
- Update new-item-from-multiple-feeds source version to 1.2.9
- Update new-item-in-feed source version to 1.2.9
- Update random-item-in-multiple-feeds source version to 0.2.9
- Refactor axios usage in rss.app.ts to use axios.request
Copy link

vercel bot commented Oct 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
pipedream-docs Ignored Ignored Oct 10, 2025 5:45pm
pipedream-docs-redirect-do-not-edit Ignored Ignored Oct 10, 2025 5:45pm

Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

Walkthrough

Updates the RSS component: adjusts HTTP request usage and headers in the app fetch logic, bumps versions for the package, one action, and three sources, adds a readOnlyHint annotation, and applies minor import order and linting comment changes. No new exported APIs; only metadata and internal request method adjustments.

Changes

Cohort / File(s) Summary of Changes
RSS App HTTP fetch/parsing
components/rss/app/rss.app.ts
Switches to axios.request(...), adds explicit User-Agent header, maintains stream-based parsing; cleans imports; adds eslint-disable annotations for any-typed params; no declared API changes.
Action: merge RSS feeds
components/rss/actions/merge-rss-feeds/merge-rss-feeds.ts
Version bump 1.2.8 → 1.2.10; adds annotations: { readOnlyHint: true }; reorders imports.
Sources: feed item triggers
components/rss/sources/new-item-in-feed/new-item-in-feed.ts, components/rss/sources/new-item-from-multiple-feeds/new-item-from-multiple-feeds.ts, components/rss/sources/random-item-in-multiple-feeds/random-item-in-multiple-feeds.ts
Version bumps: 1.2.7 → 1.2.9 (two files), 0.2.7 → 0.2.9 (one file); import order tweaks; adds an eslint-disable comment in one source.
Package manifest
components/rss/package.json
Component version bump 0.5.8 → 0.5.10; no dependency changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Src as Source/Action
  participant RSS as RSS App
  participant HTTP as axios.request
  participant Parser as Feed Parser

  Src->>RSS: fetchFeed(url)
  RSS->>HTTP: GET url with headers (User-Agent, etc.)
  HTTP-->>RSS: Response stream
  RSS->>Parser: pipe stream and parse
  Parser-->>RSS: items
  RSS-->>Src: items
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A twitch of whiskers, headers set just right,
I hop through streams in soft moonlight.
Versions bud like clover new,
Imports shuffle, tidy too.
With a gentle thump, I parse and read—
Carrots cached, I merge each feed. 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (4 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The pull request title is verbose and replicates the issue title rather than succinctly summarizing the core change, and it includes the issue number and inconsistent formatting which reduces clarity. Consider reformatting the title to a concise description of the change, for example “Fix New Item in Feed trigger rejecting valid Dotclear RSS and Atom feeds,” and remove the issue number.
Linked Issues Check ⚠️ Warning The changes in this pull request only include version bumps, import reordering, and lint annotations without any modifications to the feed validation or parsing logic required to accept Dotclear-generated RSS or Atom feeds as described in issue #11226. Add or update the parsing and validation logic in the New Item in Feed source so that it recognizes and accepts the provided Dotclear RSS and Atom feeds, and include appropriate tests for those feed URLs.
Out of Scope Changes Check ⚠️ Warning This pull request introduces version bumps and import reorganizations across multiple RSS components that are unrelated to fixing the New Item in Feed trigger for Dotclear feeds as specified in the linked issue. Restrict the pull request to only include changes necessary to address the bug in the New Item in Feed source and move unrelated version bumps or refactoring into separate PRs.
Description Check ⚠️ Warning The pull request description does not follow the repository’s required template, as it only states “Resolves #11226” and omits the “WHY” section and any rationale or implementation details. Populate the description using the provided template by adding a “## WHY” section that explains the motivation for the change, the problem being solved, and a summary of what was implemented.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 11226-bug-create-trigger---new-item-in-feed-ends-to-error-not-a-feed-with-my-rssatom

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
components/rss/app/rss.app.ts (1)

57-79: Guard against missing dependency before release.

This block now relies on the external axios package, but the module isn’t bundled anywhere unless it’s listed in components/rss/package.json. Without that addition, this import will throw at runtime. Please add axios as a dependency in the package manifest to keep this code working.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c888bba and ad2e919.

📒 Files selected for processing (6)
  • components/rss/actions/merge-rss-feeds/merge-rss-feeds.ts (1 hunks)
  • components/rss/app/rss.app.ts (7 hunks)
  • components/rss/package.json (1 hunks)
  • components/rss/sources/new-item-from-multiple-feeds/new-item-from-multiple-feeds.ts (3 hunks)
  • components/rss/sources/new-item-in-feed/new-item-in-feed.ts (1 hunks)
  • components/rss/sources/random-item-in-multiple-feeds/random-item-in-multiple-feeds.ts (2 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
components/rss/app/rss.app.ts (1)
components/spotify/actions/get-album-tracks/get-album-tracks.mjs (1)
  • axios (53-56)
components/rss/actions/merge-rss-feeds/merge-rss-feeds.ts (1)
types/src/index.ts (1)
  • defineAction (402-408)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Lint Code Base
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Verify TypeScript components
  • GitHub Check: pnpm publish
🔇 Additional comments (3)
components/rss/actions/merge-rss-feeds/merge-rss-feeds.ts (3)

8-8: Verify the version skip from 1.2.8 to 1.2.10.

The version jumps from 1.2.8 to 1.2.10, skipping 1.2.9. This pattern appears across multiple RSS components in this PR (e.g., package 0.5.8→0.5.10, sources 1.2.7→1.2.9). While this might be intentional, please confirm whether 1.2.9 was used elsewhere or if this skip is a versioning strategy.


9-13: Good addition of readOnlyHint annotation.

Adding readOnlyHint: true is appropriate for this action, as it only reads and merges RSS feeds without modifying any state. This correctly indicates the action's read-only nature.


24-32: Confirm that the actual bug fix is implemented in the RSS app file.

This action calls this.rss.fetchAndParseFeed(url) on line 27, but no logic changes are visible here. Based on the PR objectives (fixing "Not a feed" error for valid Dotclear RSS/Atom feeds) and the AI summary (HTTP request/header adjustments), the actual fix should be in the rss.app.ts file where fetchAndParseFeed is implemented. The version bump here indicates related changes were made, but please verify that the HTTP request logic in the app file properly handles the Dotclear feed format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 'Create Trigger' -> 'New Item in Feed' ends to 'Error: Not a feed' with my rss/atom

1 participant