-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Implement 'Get Board Items Page' action and update version to 0.9.0 #18714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Added a new action to retrieve items from a specified board page. - Introduced GraphQL query for fetching board items with pagination support. - Updated package version to 0.9.0.
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughAdds a new Monday action that paginates board items via a new GraphQL query and app method, aggregates and returns all items, and increments many Monday component action/source versions plus the package version. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Action as Get Board Items Page Action
participant App as Monday App SDK
participant API as Monday GraphQL API
User->>Action: Run(boardId)
loop while cursor != null
Action->>App: listBoardItemsPage({ boardId, cursor })
App->>API: GraphQL: listBoardItemsPage query
API-->>App: { items_page: { cursor, items[] }, errors? }
App-->>Action: response
alt response.errors
Action-->>User: throw error (stop)
else
Action->>Action: append items, set cursor
end
end
Action-->>User: return aggregated items + summary
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Bumped version numbers for various actions including Create Board, Create Column, Create Group, Create Item, Create Subitem, Create Update, Get Column Values, Get Items By Column Value, Update Column Values, and Update Item Name. - Updated version numbers for sources such as Column Value Updated, Name Updated, New Board Created, New Item Created, New Sub-Item Created, New Sub-Item Update, New User Created, Specific Column Updated, Sub-Item Column Value Updated, and Sub-Item Name Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
components/monday/common/queries.mjs (1)
108-120
: Consider adding explicit ordering for consistent pagination.The query lacks an
order_by
parameter. Compare withlistItemsBoard
(lines 57-69), which specifiesquery_params: {order_by:[{ column_id: "__creation_log__", direction: desc }]}
. Without explicit ordering, pagination may return items in an inconsistent or nondeterministic order, especially if items are added/modified between requests.Apply this diff to add consistent ordering:
listBoardItemsPage: ` query listBoardItemsPage ($boardId: ID!, $cursor: String) { boards (ids: [$boardId]){ - items_page (cursor: $cursor) { + items_page (cursor: $cursor, query_params: {order_by:[{ column_id: "__creation_log__", direction: desc }]}) { cursor items { id name } } } } `,components/monday/actions/get-board-items-page/get-board-items-page.mjs (1)
1-1
: Review the common import choice.The action extends
common
fromcolumn-values.mjs
, but it doesn't perform any column value filtering—it retrieves all board items. Consider whether a more generic common module or base action would be more appropriate.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
components/monday/actions/get-board-items-page/get-board-items-page.mjs
(1 hunks)components/monday/common/queries.mjs
(1 hunks)components/monday/monday.app.mjs
(1 hunks)components/monday/package.json
(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
components/monday/actions/get-board-items-page/get-board-items-page.mjs (1)
components/monday/monday.app.mjs (2)
cursor
(494-494)items
(493-493)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
🔇 Additional comments (2)
components/monday/package.json (1)
3-3
: LGTM!The version bump from 0.8.2 to 0.9.0 appropriately reflects the addition of a new action feature.
components/monday/monday.app.mjs (1)
328-335
: LGTM!The new
listBoardItemsPage
method follows the established pattern in this file for delegating tomakeRequest
with the appropriate query and variables.
components/monday/actions/get-board-items-page/get-board-items-page.mjs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/monday/actions/create-column/create-column.mjs (1)
10-10
: LGTM! Version bump is appropriate.The patch version increment aligns with the broader package version update (0.8.2 → 0.9.0) and follows semantic versioning correctly for unchanged functionality.
As a minor optimization for future releases, consider bumping action versions selectively—only when their functionality changes or when dependencies (like the app module or queries) are updated. This can help users quickly identify which actions have meaningful updates.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (20)
components/monday/actions/create-board/create-board.mjs
(1 hunks)components/monday/actions/create-column/create-column.mjs
(1 hunks)components/monday/actions/create-group/create-group.mjs
(1 hunks)components/monday/actions/create-item/create-item.mjs
(1 hunks)components/monday/actions/create-subitem/create-subitem.mjs
(1 hunks)components/monday/actions/create-update/create-update.mjs
(1 hunks)components/monday/actions/get-column-values/get-column-values.mjs
(1 hunks)components/monday/actions/get-items-by-column-value/get-items-by-column-value.mjs
(1 hunks)components/monday/actions/update-column-values/update-column-values.mjs
(1 hunks)components/monday/actions/update-item-name/update-item-name.mjs
(1 hunks)components/monday/sources/column-value-updated/column-value-updated.mjs
(1 hunks)components/monday/sources/name-updated/name-updated.mjs
(1 hunks)components/monday/sources/new-board/new-board.mjs
(1 hunks)components/monday/sources/new-item/new-item.mjs
(1 hunks)components/monday/sources/new-subitem-update/new-subitem-update.mjs
(1 hunks)components/monday/sources/new-subitem/new-subitem.mjs
(1 hunks)components/monday/sources/new-user/new-user.mjs
(1 hunks)components/monday/sources/specific-column-updated/specific-column-updated.mjs
(1 hunks)components/monday/sources/subitem-column-value-updated/subitem-column-value-updated.mjs
(1 hunks)components/monday/sources/subitem-name-updated/subitem-name-updated.mjs
(1 hunks)
✅ Files skipped from review due to trivial changes (8)
- components/monday/sources/name-updated/name-updated.mjs
- components/monday/sources/new-item/new-item.mjs
- components/monday/actions/create-update/create-update.mjs
- components/monday/sources/new-board/new-board.mjs
- components/monday/actions/update-item-name/update-item-name.mjs
- components/monday/sources/subitem-column-value-updated/subitem-column-value-updated.mjs
- components/monday/sources/new-subitem/new-subitem.mjs
- components/monday/sources/specific-column-updated/specific-column-updated.mjs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (10)
components/monday/sources/new-user/new-user.mjs (1)
9-9
: Version bump looks good.Confirmed the source metadata now reflects 0.0.11 as expected for this release.
components/monday/sources/new-subitem-update/new-subitem-update.mjs (1)
9-9
: LGTM! Version bump aligns with package release.The version increment from
0.0.8
to0.0.9
is appropriate for this package release.components/monday/actions/get-column-values/get-column-values.mjs (1)
8-8
: Version bump looks good.Metadata aligns with the wider 0.9.0 release.
components/monday/actions/create-item/create-item.mjs (1)
11-11
: LGTM! Version bump aligns with coordinated release.The patch version increment from 0.1.2 to 0.1.3 is appropriate for a coordinated release with the new get-board-items-page action and package version 0.9.0.
components/monday/actions/create-subitem/create-subitem.mjs (1)
11-11
: LGTM! Version bump aligns with coordinated release.The patch version increment is appropriate as part of the broader package release to 0.9.0, even though this action has no functional changes.
components/monday/actions/get-items-by-column-value/get-items-by-column-value.mjs (1)
9-9
: LGTM! Coordinated metadata version bump.The patch version increment aligns with the broader package update (0.8.2 → 0.9.0) and reflects no breaking changes in this action module.
components/monday/actions/create-group/create-group.mjs (1)
8-8
: LGTM!The version bump aligns with the package-level version update and follows semantic versioning correctly.
components/monday/sources/column-value-updated/column-value-updated.mjs (1)
9-9
: LGTM! Version bump aligns with package release.The version increment from 0.0.9 to 0.0.10 is appropriate as part of the coordinated release for package version 0.9.0, which introduces the new get_board_items_page action.
components/monday/sources/subitem-name-updated/subitem-name-updated.mjs (1)
9-9
: Version bump acknowledged.The version increment from "0.0.8" to "0.0.9" is part of the broader package version update to 0.9.0. No functional changes were made to this source.
components/monday/actions/create-board/create-board.mjs (1)
9-9
: Ignore version bump changes across actions Version increments in each unchanged action module align with the project’s release process when bumping the package version; no edits required.Likely an incorrect or invalid review comment.
- Changed the action description to specify that it retrieves all items from a board, enhancing clarity for users. Updated the documentation link accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves #18610
Summary by CodeRabbit
New Features
Chores