Prefer TBB CMake Config Files (OneTBB) #1368
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two changes:
REQUIRE_TBBso that the build will fail if TBB is not found.The second change is potentially more contentious, but we ran into an issue where TBB wasn't being found and quietly being switched off as a result. The warning in the output log was not noticed and it wasn't until later that it was discovered that this mis-configuration meant that there were no TBB OpenSubdiv symbols present. I am not sure if this pattern is one that is amenable, but it would be nice to have a convention to prevent the build from continuing when a dependency is not found. The default behavior remains to quietly drop the dependency.