Skip to content

Conversation

@danrbailey
Copy link

This makes two changes:

  • Prefers to use the TBB CMake config files that ship with OneTBB (if available).
  • Add a new REQUIRE_TBB so that the build will fail if TBB is not found.

The second change is potentially more contentious, but we ran into an issue where TBB wasn't being found and quietly being switched off as a result. The warning in the output log was not noticed and it wasn't until later that it was discovered that this mis-configuration meant that there were no TBB OpenSubdiv symbols present. I am not sure if this pattern is one that is amenable, but it would be nice to have a convention to prevent the build from continuing when a dependency is not found. The default behavior remains to quietly drop the dependency.

@davidgyu
Copy link
Member

davidgyu commented Oct 6, 2025

Filed as internal issue #OSD-467

@davidgyu davidgyu changed the base branch from release to dev October 7, 2025 00:25
@davidgyu
Copy link
Member

We removed OpenSubdiv's FindTBB module a while ago in #1319, but agree that specifying CONFIG mode here makes this even more explicit. We merged a simpler fix as #1374.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants